From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B8E0D7734F for ; Tue, 20 Jul 2021 13:29:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB9EE2FC3E for ; Tue, 20 Jul 2021 13:29:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EB0602FC33 for ; Tue, 20 Jul 2021 13:29:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BB19041ABA for ; Tue, 20 Jul 2021 13:29:41 +0200 (CEST) Date: Tue, 20 Jul 2021 13:29:21 +0200 From: Oguz Bektas To: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Proxmox VE development discussion References: <20210714095151.138084-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210714095151.138084-1-o.bektas@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 1.417 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 11:29:42 -0000 any news here? On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: > unmanaged containers should run the unified cgroupv2 code from our base > plugin so that they can start correctly instead of erroring out > > Tested-by: Stoiko Ivanov > Reviewed-by: Stoiko Ivanov > Signed-off-by: Oguz Bektas > --- > v2-> v3: > * added comment from stoiko's reply > > > src/PVE/LXC/Setup.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm > index 9abdc85..4408dcc 100644 > --- a/src/PVE/LXC/Setup.pm > +++ b/src/PVE/LXC/Setup.pm > @@ -424,6 +424,10 @@ sub get_ct_os_release { > sub unified_cgroupv2_support { > my ($self) = @_; > > + # code in base plugin is a generic check and should work > + # for most distributions > + $self->{plugin} //= 'PVE::LXC::Setup::Base'; # unmanaged > + > $self->protected_call(sub { > $self->{plugin}->unified_cgroupv2_support(); > }); > -- > 2.30.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >