From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3E54D1FF2A7 for ; Fri, 19 Jul 2024 14:31:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 46A1932B3E; Fri, 19 Jul 2024 14:32:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PYKC5xGghInQ0WiuC32hcAbIoDSl1zvATrHZEkW6tmUu2qSi1oQWii6nxWMA6Yv4C6r4CfvZtxSIZoyZ5375vs9Wd7U3RVIbvtrYElqe6dxXiNrlxxhKIZnXRNGYlwzqfOMkNN0Oo4zdsOSVYv85rFSbMHyJrFs1bNekS1gOXRQMpCN43mBaMrOpUSDbhFtzYDK1prspChLVXSP/291d8n0VY1ToL0XQnXWP2MShipQ0vtcotLhDgoBG/Dsl63274lECYwFBurf3Tsj1qdHOPtbY9k0DRO+KNA7pmrsfloG/1FJz0XTcw+R67NnsigEfDfRaNxvAWUn9kBTte4Fkyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcWUEjwNsSYvP2SsIUnj112bZKP1wk5bpNrOoBn4rd0=; b=vuctOXyX0k2OtRt1ctMTKuRW9HIlG+PWNfCTujMGOnswEyNoM2p9Op9y4N7AZJ3IC9YDyL8HquwUk6ANIiJUZuGwV4+V3cMAMfw7eO0hKvpfcHyLNRzjxKarr4Sht2oiig73jcq7PY22OotBrTqI4d/YIzuefsddrQBbTwMHG/97u/j0KztmKoQM8APFnV2fRCH2cBa0TmyVb8opi4YJzwqdIRHKyGHLWs8aAB3H+y2z/nvcmlK7lFWCCWOPu+5cUHkzTUShAf5rhoWBimcu2AA0o3MbOx/gjAKugz7pFo0t9tYn3eG6NcjIQvFfdUamcr7zHUVxMRzZTVVv/9mFOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=brg9.at; dmarc=pass action=none header.from=brg9.at; dkim=pass header.d=brg9.at; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brg9.onmicrosoft.com; s=selector2-brg9-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcWUEjwNsSYvP2SsIUnj112bZKP1wk5bpNrOoBn4rd0=; b=GUnyBAm02x9g5Xbc/Hs7i1F/moRB/TddqN2Hwpj8J1/zZ+6bIiQCVgvga7DbrIgz+rkXqURz/LxuApgDtbeDvblDU6zneJ9SV6D+fYwailP736OEdummRIsVL1JXeY1kVdTK8krx+4DB5aD7ZHaHRexxL8IE/rhYCmkS2EZbMjw= From: Igor Moritz Thaller To: "pve-devel@lists.proxmox.com" Thread-Topic: [pve-devel] [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI Thread-Index: AQHa2dKnyfS23+xy/ESGp4UCvZJyWQ== Date: Fri, 19 Jul 2024 12:17:10 +0000 Message-ID: References: <20240701141040.643701-1-m.carrara@proxmox.com> In-Reply-To: <20240701141040.643701-1-m.carrara@proxmox.com> Accept-Language: de-AT, en-US Content-Language: de-AT X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=brg9.at; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3902:EE_|DU0PR03MB9826:EE_ x-ms-office365-filtering-correlation-id: aa406e98-48ec-4926-7701-08dca7ecb6e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|41320700013|366016|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?+twdrXRQ14DMA7+Petb1hr5Xf6FUMeeMzViTzSFnD0/iS4Iq17XSD/xGKm?= =?iso-8859-1?Q?E6nWmWiwELXKuWTmAIjolRMhQWs/2lsJ/0+34BBdlGfjl74tohvofmg95H?= =?iso-8859-1?Q?wI0zEKumyZezF70M6ImCI8I/2zpxK8kGJ5pwzZdgxEGoWF3ep+s6kN3TR5?= =?iso-8859-1?Q?eWH8FX8fgYwxyu2+a56xVdsJrVFI4vBvqq9q8BozOkdNqtVz1G5IxWIGVj?= =?iso-8859-1?Q?edoRoDNUTgkqvSShmQKLS33Bglx9V44IgpZu0yduYKk5Df+CKjeYpGmG5r?= =?iso-8859-1?Q?P0lDjtHlj16qF5lKI0pqrxX5wz3Jhl1zgI0KswhubH8T9s8SzUOq7KUWbS?= =?iso-8859-1?Q?Dpj9KBAzO7BdvOMymkX/+OOp/NvptzM0qFoZ818LwlTJjsbbQbKTgF48gZ?= =?iso-8859-1?Q?KgYSm9nnKEgqetAMFKwH9YZVLNBUQ/avR9MlgPlzIJxS+cZWiDxo04DNQt?= =?iso-8859-1?Q?E2h1w+TGKzbCDiMlWl8Z8oBRTp0oMx4RaP6wXD3L5hEcMxrCXm8wCcNoYh?= =?iso-8859-1?Q?yjknGXeNUZP1twtfIUard2VgV5FB0uXawjal9nIg6LOA0eTCwDBnADlVHT?= =?iso-8859-1?Q?JyR4sbyBG3bUe24IEdmmzjysLkO5iHUCzmPupjE+WrFo+os2GpDmnu610W?= =?iso-8859-1?Q?KnL1rdZ8TpQM0ZcjwN9bCKW0eYNL2RpM2gq0hX1ctVrRX1oKinfHg9Gbga?= =?iso-8859-1?Q?ObYgsaUDddK+rOugP2kjKp6D9dqbeZtEnbnZdEfLQNofzn3vFUXcZjJQYs?= =?iso-8859-1?Q?Xf1l6bzNz6eR0yBzK/zykF2KrX0ZnKOYkvJUbRe2Cc/HZK+sdARWM/YDFv?= =?iso-8859-1?Q?+r7PWfMSlNjdKX1wSMVVghgxBc+kNnd3K9gf9xcKtFno26zRQKx0U8lb1C?= =?iso-8859-1?Q?g/3lICP1FqGzd4xyOFhhoYgEsZNTlYDI6AMmeyyCvP2hwXivWZmYJHUWGB?= =?iso-8859-1?Q?n6ti4b3OUHuVul5TjhZe6xbEixlR5Jd+2y0uiwfDxaPyA0wcAjfu5MgyHG?= =?iso-8859-1?Q?UUOjUpfTF/EQbg46NLusm+u9HtDKCa88RQ10ghFqTTI7mZE9DWJcOpb2Ls?= =?iso-8859-1?Q?SRikmA2uB+SdBRtUoExfXRfoqRC9kPL636JCJCPlJdyXE4pe/R+KOBw6Ud?= =?iso-8859-1?Q?we98zX2EkZ02QPvgG3QlxrNpvo59xprrh9QtpRelE8W218N3TVrZRFPR1u?= =?iso-8859-1?Q?rsBkF1x7mk4Fj1V0tLCEd51AnTojjbREK2KG1t+nAayL6BmLmadckWyB9j?= =?iso-8859-1?Q?3PWEG0+aMlK9a5oMrncBkVSu3V2Cs139SXz6pBbdUlLrmlXMb1SGRSjgoP?= =?iso-8859-1?Q?le3CuntMQ8eJhODwEUy6h5IlVycB7pQFxmJDiAZr94kg9hByiZ/taYZys7?= =?iso-8859-1?Q?g1bv4P1SDgOL6IeF7NtrSfD+7ZWoXHWHlIWw2SdYG58ahReXgrRkk=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR03MB3902.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(41320700013)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?RUv1Jvi2+ESEid1CZV6sWIi1gRblDOtlUZNJGs1W/Q+ddfA2irt88aPKVi?= =?iso-8859-1?Q?/z4WNP/VeAhnHvcWt4VPxrVTd6UFSOXLka5Q1ge6TuG1C/5QS9Nnzg5Wuc?= =?iso-8859-1?Q?D/Y8OIvWHKjv1sqgR7p6N234kUDiLXbTS6/3rYIL7q0LREzGNDHeW3lgds?= =?iso-8859-1?Q?7bawufEDBWLD8ByHodHva0efdZITXkqANWGD0Zy3UQS7P8vCnw0fZUTDA/?= =?iso-8859-1?Q?pxPoAgrcvZiSAZ5qBweTHFGA6GZyArztvPQUNAMyGogY7TcT4NmIXbKXRp?= =?iso-8859-1?Q?1jnxPB0U+HrjGsF7APMi8wnOh2laUDi7c2kqcUoo2+JmLJ9k92AZdlWq7z?= =?iso-8859-1?Q?2gcM9Rh+J7lCUHrvvTs0U0+y0/IvozTaPT4KmbYwvpHyOjBGDMMBlliMlw?= =?iso-8859-1?Q?e3bkTAHYe3JfpiiXo84eEU3MbaVEZ5HTK059syR4pzALaRXfOzYpiqDagy?= =?iso-8859-1?Q?7yuBDf3dIjE27hTCkqL+zWlBktQLhydMmP2Em1413pt8RGrG+ADKkf6bSe?= =?iso-8859-1?Q?LhxRgId7MRKnErh6WAuFSQpn6VVInI4Qyz4WFo8+y9FLdc0Ttqs0T8rWwB?= =?iso-8859-1?Q?kfSjJ6RRx9vEyiR3sgniQYI2WgggpGuSWZekQ8NChIMSkyg4JvoA6N1h/4?= =?iso-8859-1?Q?CPn5Zp9a3frwPOZ6fIWRAK1StOBzPPv3IDRzxSvgUdXEvpiP39UvrhtYo5?= =?iso-8859-1?Q?XHWj82NrdSQz4yiK9Qo3MGSdSVIkuN3l0IXVtPpbg0p1AcxIn/3TRo49hB?= =?iso-8859-1?Q?5ZWrlDrQT3XQS8HcrEo/7mDuu0UkY9QThbKMhDIHZOR2x+3HefBo7gPK7m?= =?iso-8859-1?Q?Nwh8jxO02eVzwwasp6ZP9EXGZBMTY8K55DbI58FCppEjs7Xza+FXnU9SEZ?= =?iso-8859-1?Q?FrTOxny3eJmmHKTuggLWngSHRqR1z8jgEllr58nAwpgP8XC6fXHqPAlkX3?= =?iso-8859-1?Q?BBK0zWJyyuO/4uSE03yJp87VjFXJhc+3r9zYMISAR+t9fzHVnM2LwYo2xO?= =?iso-8859-1?Q?RhWAHUmA/USOhYtq7RBYAht3cZAjgXiKTLPF1uxdTMO07Q/Z7zxhXYKNug?= =?iso-8859-1?Q?v9y8q2fazbgx+FyYQo5BXAhymg43ifBQAooGolR3oU3+UwbMWl0ETo9QIG?= =?iso-8859-1?Q?AB7boyVI5BXAKdzPlfcTa4s30+scZ5VNJL9axgDiDYv7n7jOnSZ0v7vmnX?= =?iso-8859-1?Q?cQPRTi07Ifvr8FzP6v7Vgi8mPnar+U4+6JoB9d0+T3Mj3CZW4o/RF36E4J?= =?iso-8859-1?Q?MFCOQyonzVehhRVRYG/dhDg8KqQFw9mkDTz47qHxuSlQ6sqcy28V4vmstb?= =?iso-8859-1?Q?uEtbavMB0XKcHfzdr4iz4GwYeTqh2ckFafD/gybVVL2QDHx+8LnwWbDW30?= =?iso-8859-1?Q?y1oK2cMbm3/TN/urixRIu/R1oGSgIBGKzUyKDacleKp13A2+vm/oiiss2f?= =?iso-8859-1?Q?UZSs3CilFMECrDJ/1f9Qh9hv8cx1HrAL7MRXDBLLQLlf2f2r1fx/MQdbvE?= =?iso-8859-1?Q?n4VnxoQCTiINykI2OrPTw4BQ6K9I4ZSgis5g+rD2C/KFIoHgbVSM75HdcS?= =?iso-8859-1?Q?dmFI3lWXI6q9c05yfnJkRsABZN2kLpyLelcDGNt/ClA49REAQPJaw+Q/rL?= =?iso-8859-1?Q?ambWlT+DYWoFg=3D?= MIME-Version: 1.0 X-OriginatorOrg: brg9.at X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3902.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa406e98-48ec-4926-7701-08dca7ecb6e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2024 12:17:10.2104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8fa1925e-52f8-46a8-82f4-8adc9af8acdb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6e0IRaRkhfsi/PnjRmeC3+K3ugxCgY+F+E/ShtTRFioATt/C+kOIDWl880Sc2w7IQvmsSlMntKSuuxASu8sejw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB9826 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [osd.pm, services.pm, tools.pm, brg9.onmicrosoft.com, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Lukas Wagner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" I have tested the new ceph GUI feature where if a cluster has an outdated ceph version running, it will inform the user. My setup consisted of a ceph cluster with three monitors and four nodes, each having their own two osds. Since I didn't want to rebuild ceph I instead modified the 'CEPH_GIT_VER' variable in the python file '/usr/bin/ceph'. I changed the ceph version multiple times to different versions/non-versions, and it correctly updated the GUI with a warning that the currently running version was outdated. Overall, from what I have tested, it works great! Tested-by: Igor Thaller ________________________________________ Von: pve-devel im Auftrag von Max Carrara Gesendet: Montag, 1. Juli 2024 16:10 An: pve-devel@lists.proxmox.com Cc: Lukas Wagner Betreff: [pve-devel] [PATCH v2 pve-manager 00/10] Ceph Build Commit in UI Ceph Build Commit in UI - Version 2 =================================== Notable Changes since v1 ------------------------ * Use camelCase instead of snake_case for new functions / variables as per our style guide [0] (thanks Lukas!) * Refrain from using `const` for things that aren't actual constants as per our style guide [1] (thanks Lukas!) * NEW: Patch 09: Increase the default width of the version field in the OSD tree so that longer strings are immediately readable without needing to adjust the column widths manually --> e.g. "18.2.2 (e9fe820e7 -> 69ce99eba)" takes up a lot of space in the column * NEW: Patch 10: Include Ceph build commit in the version string which is part of the object of the `ceph/osd/{osdid}/metadata` call For a detailed list of changes, please see the comments in the individual patches. NOTE: I added Lukas's T-b and R-b tags to all patches except the new ones, as mentioned in a reply to v1 [2]. Older Versions -------------- v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063772.html References ---------- [0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing [1]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables [2]: https://lists.proxmox.com/pipermail/pve-devel/2024-June/064084.html Summary of Changes ------------------ Max Carrara (10): ceph: tools: refactor installation check as guard clause ceph: tools: parse Ceph version in separate sub and update regex ceph: services: remove old cluster broadcast ceph: services: refactor version existence check as guard clause utils: align regex of parse_ceph_version with Perl equivalent ui: ceph: services: parse and display build commit api: ceph: add build commit of host to Ceph osd index endpoint data ui: ceph: osd: rework rendering of version field & show build commit ui: ceph: osd: increase width of version column api: ceph: change version format in OSD metadata endpoint PVE/API2/Ceph/OSD.pm | 9 ++++- PVE/Ceph/Services.pm | 38 ++++++++++---------- PVE/Ceph/Tools.pm | 59 ++++++++++++++++++++++---------- www/manager6/Utils.js | 17 ++++++++- www/manager6/ceph/OSD.js | 57 +++++++++++++++++++++++++----- www/manager6/ceph/ServiceList.js | 32 +++++++++++++---- www/manager6/ceph/Services.js | 14 +++++++- 7 files changed, 170 insertions(+), 56 deletions(-) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel