From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F08D5606F5 for ; Tue, 11 Jan 2022 00:30:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D497818077 for ; Tue, 11 Jan 2022 00:30:03 +0100 (CET) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 301FD18061 for ; Tue, 11 Jan 2022 00:30:02 +0100 (CET) Received: by mail-ot1-x331.google.com with SMTP id i5-20020a05683033e500b0057a369ac614so16771399otu.10 for ; Mon, 10 Jan 2022 15:30:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfspaw.com; s=google; h=content-transfer-encoding:from:mime-version:date:subject:message-id :to; bh=o/P4twZ6T5BJLJ/qn9KwhA1gGjhsUSEh40p1uJwaLBk=; b=jmkShZOBRnHVRzLBmQRaUt6vcprCsKqkYrWuMrOZ5KwnRqttydQ63nb+B83ef2GEjt eelIteH2SblqU3LKwUw6d5rncdtAVZ4lHql4fODwC5JRurbHDSriDwA7FVW/qGCsHzPG P0N7b1YZQKs2M05gLbnOFiqg7pAonffSg5oNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:content-transfer-encoding:from:mime-version:date :subject:message-id:to; bh=o/P4twZ6T5BJLJ/qn9KwhA1gGjhsUSEh40p1uJwaLBk=; b=69Fryuk+QSFDpDOP+OiaT1389wnM4n3YA/keHOpXefzO1WrXNY5h6pCED6KgxS1/Xi 6pRgTcRXaZ9hwGZxQaQskmB77ahVYnzQNUZp5U+msPHBIy0Df99p9p+/NI1+Nc5PF/1k M/NGyx31ArjK+PB0FcRc71Y6Vjj3OLoaPZOUzJbwdL3rJNpom1O6ooKhLSI0cSd6e8vx NoZVVfeJkPQUwPjeWyb2bX+dstCWUL74xYL143M11k6aAc6ln3aY5jy0XrZnVBFmO2J8 4kaVvoy5x27OX4v2DTB+mXmitzo2ln9LtMTPVkmV2b5zW/fhVV+a4lDSHtg3iQMJETL7 90Fg== X-Gm-Message-State: AOAM5300O4jh+cnOH7p2EM2Roo9y6pQyzwYsn8I8xKcvm7Uvv43itIFN cNhjcA0Zhfm2riyTKoM7RHIrFQ== X-Google-Smtp-Source: ABdhPJzu52BHLjGpepTFcsw8Klmicu0yoo8LqbAHfUWIqVkr862c0+eq2F+WqPfvp6IwzYLxTtGRnA== X-Received: by 2002:a9d:685:: with SMTP id 5mr1535722otx.255.1641857394514; Mon, 10 Jan 2022 15:29:54 -0800 (PST) Received: from smtpclient.apple (who.wolfspaw.com. [108.221.46.19]) by smtp.gmail.com with ESMTPSA id k8sm1600398oon.2.2022.01.10.15.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 15:29:53 -0800 (PST) From: Wolf Noble Mime-Version: 1.0 (1.0) Date: Mon, 10 Jan 2022 17:29:53 -0600 Message-Id: To: pve-devel@lists.proxmox.com X-Mailer: iPhone Mail (19D5026g) X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_INVALID 0.1 DKIM or DK signature exists, but is not valid DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid HTML_MESSAGE 0.001 HTML included in message KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment MIME_QP_LONG_LINE 0.001 Quoted-printable line longer than 76 chars RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-Mailman-Approved-At: Tue, 11 Jan 2022 18:28:23 +0100 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [pve-devel] zfs max record size tunable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2022 23:30:34 -0000 hi all! i recently was playing with the ZOL module parameters, while tuning compress= ion algos for my filer, and ran into a scenario that would be valuable knowl= edge here as well (i think) not to go down the rabbit hole of why one might or might not want to do this= too far, but TLDR: recordsize controls the chunk size of data handed to wha= tever compression algorithm is in use for that fs/vol, and it can increase t= he compression attained in some cases (and many relevant to pxm imo, but=E2=80= =A6 tangent=E2=80=A6 :) ) if you increase the max record size on a host (default is 1Mb, max is 16mb) = via the kernel module tunable, it=E2=80=99s set ba k to default on reboot=E2= =80=A6 now, vols/fs with larger recordsize than kernel module has configured= is fine. no problems occur. BUT. if you try to create a file system/vol with a larger recordsize than th= e module (currently) allows, zfs complains. this is especially problematic when using zfs replication=E2=80=A6 if you tr= y to send a fs/vol/snapshot which has a recordsize larger than target host s= upports, the send fails oddly. i can see both sides of bug/feature mindset=E2=80=A6 but what i figured was r= elevant here contextually is that it might be worth adding some logic to eva= luate the recordsize and the relevant module tuning and make some noise if t= he user tries to do something that won=E2=80=99t work and won=E2=80=99t be o= bvious why.. if this does not feel relevant here, mea culpa. im really a fan of the way pxm works=E2=80=A6 y=E2=80=99all have done a real= ly nice job stitching a lot of complicated things together well. thank you for making my life as an admin of infra easier. i really appreciate it. UNRELATED FEEDBACK: i would love it if there was a stream of =E2=80=9Ccommand line executions pe= rformed on your behalf in response to you driving the UI=E2=80=9D that the u= ser could observe (the ui is almost doing this already, just not quite as ve= rbosely ((or durably)) as i had in mind=E2=80=A6 i was thinking of sort-of=E2= =80=A6 =E2=80=9Cadmin by osmosis mode=E2=80=9D wherein a novice user could e= ducate themselves by performing ops and observing the cmdline log file essen= tially=E2=80=A6 the reason behind this stems from things like: i need to take node X out for maintenance=E2=80=A6 i want to evacuate all th= e vms=20 or=20 i need to upgrade node X=E2=80=99s storage=E2=80=A6 evacuate all vms and des= troy all ceph OSDs on it=E2=80=A6 that=E2=80=99s not really easy to do via the existing UI, and seeing the exa= ct cmds pxm is doing for me under the covers would help scripting something s= ane=E2=80=A6=20 alternatively, adding some entire-host scoped one-click UI features would he= lp alleviate this scenario too=E2=80=A6 so=E2=80=A6 if that=E2=80=99s someth= ing in the works=E2=80=A6 great =E2=9D=A4=EF=B8=8F=F0=9F=A4=A1=F0=9F=90=BAW [=3D The contents of this message have been written, read, processed, erased= , sorted, sniffed, compressed, rewritten, misspelled, overcompensated, lost,= found, and most importantly delivered entirely with recycled electrons =3D]=