From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B7DD01FF0AF for ; Fri, 20 Nov 2026 09:43:09 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6511E216CA; Fri, 20 Nov 2026 09:43:09 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Nov 2026 09:43:02 +0100 Message-Id: Subject: Re: [PATCH pve-cluster v2 10/19] fix #7993: datacenter config: ad ha-{cpu,mem}-weight crs options From: "Daniel Kral" To: "Dominik Rusovac" , X-Mailer: aerc 0.22.0-45-gc30c872fde7b-dirty References: <20261112094437.1951271-1-d.rusovac@proxmox.com> <20261112094437.1951271-11-d.rusovac@proxmox.com> In-Reply-To: <20261112094437.1951271-11-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795164182819 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.432 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q3IAVGSZ54YQXDXKSHT5KWMHBCERCTDG X-Message-ID-Hash: Q3IAVGSZ54YQXDXKSHT5KWMHBCERCTDG X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote: > add weights controlling how much balancing the CPU load, respectively > the memory usage, of nodes is prioritized relative to each other by the > static and dynamic scheduling modes > > the weights are not specific to automatic rebalancing, as they are also > used when selecting a node to start or recover a resource on, so they do > not require 'ha-auto-rebalance' > > if neither weight is set, the previous behavior is kept: selecting a > node and the TOPSIS method favor memory usage 5 times over CPU load, > while the bruteforce method weighs both equally. if only one weight is > set, the other one defaults to 1 > > Signed-off-by: Dominik Rusovac > --- > > Notes: > changes since v1: > * rename ha-auto-rebalance-{cpu,mem}-weight, as the weights are not > auto-rebalance specific > * add verbose_description > * reword commit > > src/PVE/DataCenterConfig.pm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..a678838 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -78,6 +78,34 @@ EODESC > description =3D> "The minimum relative improvement in cluster no= de imbalance," > . " in percent, to commit to a resource balancing migration.= ", > }, > + 'ha-cpu-weight' =3D> { > + type =3D> 'integer', > + optional =3D> 1, > + minimum =3D> 0, > + default =3D> 1, > + description =3D> "How much balancing the CPU load of nodes is pr= ioritized, relative to" > + . " 'ha-mem-weight'. Used for the 'static' and 'dynamic' sch= eduler modes.", > + verbose_description =3D> "How much balancing the CPU load of nod= es is prioritized," > + . " relative to 'ha-mem-weight'. Used for the 'static' and '= dynamic' scheduler" > + . " modes, both for selecting a node to start or recover a r= esource on and for" > + . " the automatic rebalancing. Only the ratio of the weights= matters. If" > + . " neither weight is set, selecting a node to start or reco= ver a resource on and" > + . " the 'topsis' rebalancing method prioritize memory usage = 5 times over CPU load.", This should also explain that setting '0' means that the CPU load is not accounted for at all. nit: Could also use a new line before the "If neither weights is set, ..." part so the quite specific case is a bit more separate from the more generic description. maybe even prefix that paragraph with "For backwards compatibility, ..." > + }, > + 'ha-mem-weight' =3D> { > + type =3D> 'integer', > + optional =3D> 1, > + minimum =3D> 0, > + default =3D> 1, > + description =3D> "How much balancing the memory usage of nodes i= s prioritized, relative" > + . " to 'ha-cpu-weight'. Used for the 'static' and 'dynamic' = scheduler modes.", > + verbose_description =3D> "How much balancing the memory usage of= nodes is prioritized," > + . " relative to 'ha-cpu-weight'. Used for the 'static' and '= dynamic' scheduler" > + . " modes, both for selecting a node to start or recover a r= esource on and for" > + . " the automatic rebalancing. Only the ratio of the weights= matters. If" > + . " neither weight is set, selecting a node to start or reco= ver a resource on and" > + . " the 'topsis' rebalancing method prioritize memory usage = 5 times over CPU load.", Same here as well > + }, > }; > =20 > my $migration_format =3D {