From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 628EC1FF0DE for ; Thu, 19 Nov 2026 15:14:27 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 36CD82171E; Thu, 19 Nov 2026 15:14:16 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 15:14:12 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH common/storage 0/3] fix #8286: do not hold inherited locks in volume cleanup workers X-Mailer: aerc 0.22.0 References: <20261105163637.1318072-1-m.koeppl@proxmox.com> In-Reply-To: <20261105163637.1318072-1-m.koeppl@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795097652194 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.178 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3EE4F7PPZCWTU6W5SI3YVPECFP5YU6ZT X-Message-ID-Hash: 3EE4F7PPZCWTU6W5SI3YVPECFP5YU6ZT X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/pve-devel/20261119141302.600137-1-m.koeppl@proxmox= .com/ On Thu Nov 5, 2026 at 5:36 PM CET, Michael K=C3=B6ppl wrote: > Destroying a VM through the API with a disk on an LVM storage with > saferemove=3D1 leaves its VMID locked until the wipe of the disk is done. > The imgdel worker is forked while the qmdestroy worker holds the > config lock and inherits the locked file handle. The worker keeps the > lock held after the qmdestroy worker exited. Re-creating a VM with the > same VMID fails with a lock timeout in the meantime. > > This series tries to keep the fix targeted, since closing all inherited [snip]