From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C03571FF0C0 for ; Wed, 18 Nov 2026 17:12:37 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6B5242176E; Wed, 18 Nov 2026 17:12:36 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Nov 2026 17:12:32 +0100 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH ha-manager v4 09/17] lrm: catch and report dies while the LRM is in maintenance state From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.22.0 References: <20261118144502.231134-1-d.kral@proxmox.com> <20261118144502.231134-10-d.kral@proxmox.com> In-Reply-To: <20261118144502.231134-10-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795018352798 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.183 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VR3T5LCJRRHWVBMAZEJQE4VZZPWNVGPN X-Message-ID-Hash: VR3T5LCJRRHWVBMAZEJQE4VZZPWNVGPN X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for adding this to v4. Looks good to me! Reviewed-by: Michael K=C3=B6ppl On Wed Nov 18, 2026 at 3:44 PM CET, Daniel Kral wrote: > This is similar in scope to the eval block in the active work branch, > where dies in watchdog releases, lock releases and manage_resources() > are caught and logged instead of making the LRM itself exit because of > these. > > Furthermore, this prevents the LRM from exiting if a transient > manager_status read error in update_service_status() causes the whole > LRM to shut down with the watchdog armed and its HA agent lock held. [snip]