From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B0BAC1FF0AA for ; Tue, 17 Nov 2026 17:05:57 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DBFEB216C0; Tue, 17 Nov 2026 17:05:45 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Nov 2026 17:05:33 +0100 Message-Id: Subject: Re: [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration To: "Mark Atwood" , X-Mailer: aerc 0.20.0 References: <20261113030652.3550-1-mark@wolfssl.com> <20261113030652.3550-2-mark@wolfssl.com> In-Reply-To: <20261113030652.3550-2-mark@wolfssl.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794931533284 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.567 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BV53D2ZZBP4LLLPDYRJL5K7NLMMFSRL2 X-Message-ID-Hash: BV53D2ZZBP4LLLPDYRJL5K7NLMMFSRL2 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Nov 13, 2026 at 4:06 AM CET, Mark Atwood wrote: > Read the new 'ticket-signature-hash' option of datacenter.cfg and pass > it to PVE::Ticket::assemble_rsa_ticket() for all tickets that are > signed here: login and TFA tickets, as well as the short-lived VNC and > tunnel tickets. Without the option, tickets are signed with SHA-1 as > before. > > This lets setups where SHA-1 signatures are not acceptable, like > running in FIPS mode, create tickets. It depends on the option in > pve-cluster and on the changes to PVE::Ticket in pve-common, which > should be applied first. With older versions of those, the option is > not set and the parameter is ignored, so tickets are still signed with > SHA-1. nit: typically we don't handle apply order of patches in the commit message itself, as once it is applied is too late for that information to be useful. rather add it in the notes section (below `---`). also sadly this does not apply anymore. -->8 snip 8<--