From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A26ED1FF0B7 for ; Fri, 13 Nov 2026 13:51:44 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7B777217F9; Fri, 13 Nov 2026 13:51:24 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:51:20 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH ha-manager v7 27/32] resources: add migrate_json_properties() method Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-28-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-28-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574280566 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.189 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R6RHHGFNKRHUYVID2TT7U4UWTVXUAGZB X-Message-ID-Hash: R6RHHGFNKRHUYVID2TT7U4UWTVXUAGZB X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 1 nit inline that I missed last time (sorry). Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: [snip] > sub type { > return 'ct'; > } > @@ -174,4 +185,10 @@ sub get_static_stats_from_config { > }; > } > > +sub migrate_json_properties { > + my ($class) =3D @_; > + init_migrate_json_properties() if !defined($ct_migrate_json_properti= es); > + return $ct_migrate_json_properties nit: this is missing a ; > +} > + > 1; > diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.p= m > index 3b61113..914f406 100644 > --- a/src/PVE/HA/Resources/PVEVM.pm > +++ b/src/PVE/HA/Resources/PVEVM.pm > @@ -22,6 +22,17 @@ BEGIN { > > use base qw(PVE::HA::Resources); > [snip]