From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CE5D21FF0B7 for ; Fri, 13 Nov 2026 13:50:58 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1646E2175D; Fri, 13 Nov 2026 13:50:52 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:50:48 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH container v7 16/32] migrate: implement fork_tunnel() method Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-17-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-17-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574248535 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.191 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FBIDNCAZO7UJEC5KG5L77UJMTO4YYRUH X-Message-ID-Hash: FBIDNCAZO7UJEC5KG5L77UJMTO4YYRUH X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: > To be used in a common check_config_on_target() method. nit: should also be `prepare_local_cluster_checks()`, unless I'm missing something here. > > Signed-off-by: Fiona Ebner > --- > > New in v7. > > src/PVE/LXC/Migrate.pm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > index d243d90..04133f4 100644 > --- a/src/PVE/LXC/Migrate.pm > +++ b/src/PVE/LXC/Migrate.pm > @@ -27,6 +27,18 @@ use base qw(PVE::AbstractMigrate); > # compared against remote end's minimum version > our $WS_TUNNEL_VERSION =3D 2; > > +sub fork_tunnel { > + my ($self, $ssh_forward_info) =3D @_; > + > + my $cmd =3D ['pct', 'mtunnel']; > + my $log =3D sub { > + my ($level, $msg) =3D @_; > + $self->log($level, $msg); > + }; > + > + return PVE::Tunnel::fork_ssh_tunnel($self->{rem_ssh}, $cmd, $ssh_for= ward_info, $log); > +} > + > sub lock_vm { > my ($self, $vmid, $code, @param) =3D @_; >