From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 01CC51FF0B6 for ; Thu, 12 Nov 2026 13:23:47 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 190E82167E; Thu, 12 Nov 2026 13:23:43 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 12 Nov 2026 13:23:39 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Thomas Lamprecht" , "Fiona Ebner" , =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid X-Mailer: aerc 0.22.0 References: <20261103124831.139399-1-f.ebner@proxmox.com> <20261103124831.139399-6-f.ebner@proxmox.com> <63919262-8934-4709-84c0-e008cb6be0ed@proxmox.com> <79a703dd-3893-4b73-b69c-0a0e847323fd@proxmox.com> <7c55d463-da77-4e66-9ca6-3a70ed2d720b@proxmox.com> In-Reply-To: <7c55d463-da77-4e66-9ca6-3a70ed2d720b@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794486219765 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.199 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EGW7BQZIAFETBWGL4W2VVACGEF4YP64C X-Message-ID-Hash: EGW7BQZIAFETBWGL4W2VVACGEF4YP64C X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 12, 2026 at 12:21 PM CET, Thomas Lamprecht wrote: > Am 12.11.26 um 12:08 schrieb Fiona Ebner: >> I would prefer a limit higher than 72. It can be quite useful for git >> oneline log if there is more context (prefixes), and more specific >> commit subjects. > > Alright, thanks for your input, so increasing is settled. What would be > your preferred guideline: > > 1. subject should be below 80cc and must be below 120cc, body still 72cc > > 2. subject should be below 100cc and must be below 120cc, body still 72c > > 3. subject should be below 80cc and must be below 100cc, body still 72cc > > 4. One of the above (which one) but unified also for the whole message > (body and subject). I agree with Fiona. 3 looks like a sensible solution to me as well. Thanks for bringing this up in any case. This should make it easier to adhere to the rule without being overly restrictive.