From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DEDE71FF0B3 for ; Wed, 11 Nov 2026 16:40:47 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4DCDC2164B; Wed, 11 Nov 2026 16:40:45 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Wed, 11 Nov 2026 16:40:41 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH qemu-server v6 21/26] migration: intra-cluster: check config can be parsed on target node Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0 References: <20261103124831.139399-1-f.ebner@proxmox.com> <20261103124831.139399-22-f.ebner@proxmox.com> In-Reply-To: <20261103124831.139399-22-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794411641383 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.202 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZHCCL5FC2SN2VT3GO4TGHZVILSL5D5SG X-Message-ID-Hash: ZHCCL5FC2SN2VT3GO4TGHZVILSL5D5SG X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Nov 3, 2026 at 1:48 PM CET, Fiona Ebner wrote: [snip] > index c715a60e..a2e97315 100644 > --- a/src/test/MigrationTest/QemuMigrateMock.pm > +++ b/src/test/MigrationTest/QemuMigrateMock.pm > @@ -66,6 +66,10 @@ $tunnel_module->mock( > my $vmid =3D $1; > die "resuming wrong VM '$vmid'\n" if $vmid ne $test_vmid; > return; > + } elsif ($command =3D~ m/^config (\d+) (\S+)$/) { > + my ($vmid, $node) =3D ($1, $2); > + die "check config for wrong VM '$vmid'\n" if $vmid ne $test_= vmid; > + return; > } > die "write_tunnel (mocked) - implement me: $command\n"; > }, > @@ -74,7 +78,12 @@ $tunnel_module->mock( > my $qemu_migrate_module =3D Test::MockModule->new("PVE::QemuMigrate"); > $qemu_migrate_module->mock( > fork_tunnel =3D> sub { > - die "fork_tunnel (mocked) - implement me\n"; # currently no call= should lead here > + return { > + writer =3D> "mocked", > + reader =3D> "mocked", > + pid =3D> 123456, > + version =3D> 1, > + }; nit: since nothing here mocks PVE::Cluster::node_pvecfg_version_at_least(), the migration tests use the real one, which returns false when there's no version info for the test's target node (which is the case for a build host that's not in a cluster). So the config check is always skipped, and the new config and fork_tunnel mocks are never reached. Instead, running the test logs "info: skipping config check - target pve-manager version < 9.2.26". > }, > start_remote_tunnel =3D> sub { > my ($self, $raddr, $rport, $ruri, $unix_socket_info) =3D @_;