From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 6EA091FF0B3
	for <inbox@lore.proxmox.com>; Wed, 11 Nov 2026 16:40:05 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id BA8F721638;
	Wed, 11 Nov 2026 16:39:58 +0100 (CET)
Content-Type: text/plain; charset=UTF-8
Date: Wed, 11 Nov 2026 16:39:55 +0100
Message-Id: <DMSHTMN6J99O.2OIJ8EBDFVBMQ@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server v6 16/26] helpers: move
 get_node_pvecfg_version() version helper to pve-cluster
From: =?utf-8?q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Mailer: aerc 0.22.0
References: <20261103124831.139399-1-f.ebner@proxmox.com>
 <20261103124831.139399-17-f.ebner@proxmox.com>
In-Reply-To: <20261103124831.139399-17-f.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1794411595209
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.204 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: U4BI544PRFU7HT2OF2MZKMU4E4O5N4QZ
X-Message-ID-Hash: U4BI544PRFU7HT2OF2MZKMU4E4O5N4QZ
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue Nov 3, 2026 at 1:48 PM CET, Fiona Ebner wrote:

[snip]

> diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.p=
m
> index cead2011..8d64e524 100644
> --- a/src/PVE/QemuServer/Helpers.pm
> +++ b/src/PVE/QemuServer/Helpers.pm
> @@ -293,16 +293,6 @@ sub config_aware_timeout {
>      return $timeout;
>  }
>
> -sub get_node_pvecfg_version {
> -    my ($node) =3D @_;
> -
> -    my $nodes_version_info =3D PVE::Cluster::get_node_kv('version-info',=
 $node);
> -    return if !$nodes_version_info->{$node};
> -
> -    my $version_info =3D decode_json($nodes_version_info->{$node});
> -    return $version_info->{version};
> -}

nit: after this change, neither PVE::Cluster nor JSON is used anymore,
but this patch leaves the unused imports behind.

> -
>  sub parse_number_sets {
>      my ($set) =3D @_;
>      my $res =3D [];