From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3A0A61FF09C for ; Mon, 02 Nov 2026 15:06:59 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7EE2E20380; Mon, 02 Nov 2026 15:06:56 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Nov 2026 15:06:50 +0100 Message-Id: To: "Mark Atwood" , Subject: Re: [PATCH access-control] csrf: drop leftover SHA-1 token fallback X-Mailer: aerc 0.20.0 References: <20261023185755.541328-1-mark@wolfssl.com> In-Reply-To: <20261023185755.541328-1-mark@wolfssl.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793628410991 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.673 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7LR2DOTSFWIKGMMBISAUBXPJCJNIZYSV X-Message-ID-Hash: 7LR2DOTSFWIKGMMBISAUBXPJCJNIZYSV X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Oct 23, 2026 at 8:57 PM CEST, Mark Atwood wrote: > verify_csrf_prevention_token still derives a SHA-1 based secret from the > www key and switches to it for tokens with a 27 character signature, as > issued by PVE 5 and older. > > This fallback stopped working when pve-common commit ff39327 ("ticket: > remove fallback for SHA1-base64 CSRF prevention tokens") made > PVE::Ticket::verify_csrf_prevention_token always compute an > HMAC-SHA-256, whose 43 character signature can never match a 27 > character one. Such tokens are therefore rejected either way, and the > build dependency on libpve-common-perl (>=3D 9.1.11) already pulls in tha= t > change. > > Remove the dead code, including the FIXME that asked for its removal > with PVE 7. This also drops the last SHA-1 use from CSRF handling. -->8 snip 8<-- Hey Mark, thanks for this patch, looks good from my perspective. Did a quick test and everything still seems to work as expected. Consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz