From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 467151FF0BC
	for <inbox@lore.proxmox.com>; Thu, 29 Oct 2026 09:43:20 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id E1F922141D;
	Thu, 29 Oct 2026 09:43:17 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 29 Oct 2026 09:43:13 +0100
Message-Id: <DMH6TI8LF3OT.V95OIN4J1HK7@proxmox.com>
Subject: Re: [PATCH ha-manager 6/7] make get_node_affinity return all
 priority classes sorted in descending order
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.22.0-10-g6373ac9d2179-dirty
References: <20260422100035.232716-1-d.kral@proxmox.com>
 <20260422100035.232716-7-d.kral@proxmox.com>
In-Reply-To: <20260422100035.232716-7-d.kral@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793263393894
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.712 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: E4QYZAWR4FHEA4BWHJ7S25O6U6U54JGS
X-Message-ID-Hash: E4QYZAWR4FHEA4BWHJ7S25O6U6U54JGS
X-MailFrom: d.kral@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Wed Apr 22, 2026 at 12:00 PM CEST, Daniel Kral wrote:
> This is in preparation of the next patch, which needs to iterate through
> the priority classes from the highest to the lowest priority class.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>

This patch misses to adapt the get_node_affinity() caller in
PVE::HA::Helpers::get_resource_motion_info().

I'll adapt it in a v2.

diff --git a/src/PVE/HA/Helpers.pm b/src/PVE/HA/Helpers.pm
index a58b1e12..96682722 100644
--- a/src/PVE/HA/Helpers.pm
+++ b/src/PVE/HA/Helpers.pm
@@ -24,7 +24,8 @@ sub get_resource_motion_info($ss, $sid, $cd, $online_node=
s, $compiled_rules) {

     my ($node_affinity, $resource_affinity) =3D
         $compiled_rules->@{qw(node-affinity resource-affinity)};
-    my ($allowed_nodes, $pri_nodes) =3D get_node_affinity($node_affinity, =
$sid, $online_nodes);
+    my ($allowed_nodes, $priority_classes) =3D get_node_affinity($node_aff=
inity, $sid, $online_nodes);
+    my $pri_nodes =3D shift @$priority_classes // {};
     my ($together, $separate) =3D get_affinitive_resources($resource_affin=
ity, $sid);

     for my $csid (sort keys %$together) {