From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 5336B1FF0AF
	for <inbox@lore.proxmox.com>; Fri, 23 Oct 2026 13:29:56 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id E7D0321631;
	Fri, 23 Oct 2026 13:29:55 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 23 Oct 2026 13:29:52 +0200
Message-Id: <DMC6LTW2ZVG8.C3TOUX5K1WK@proxmox.com>
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-container] lxc: pass hostname correctly when giving
 up an ip address
X-Mailer: aerc 0.20.0
References: <20260819133459.915481-1-h.laimer@proxmox.com>
In-Reply-To: <20260819133459.915481-1-h.laimer@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792754992572
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.493 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: T7BM7R5Z6P5XUJITN5UPH2GUFTD5FUCW
X-Message-ID-Hash: T7BM7R5Z6P5XUJITN5UPH2GUFTD5FUCW
X-MailFrom: e.huhsovitz@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Needs rebase onto master.

I was unable to find any mention of a container 'name' in the guest config.

I checked the config for all of my containers, and the $conf in=20
always contains a 'hostname' key, never a 'name'.

So consider this

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Wed Aug 19, 2026 at 3:34 PM CEST, Hannes Laimer wrote:
> A container has no `name`, only a `hostname`. This led to left behind
> DNS records.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  src/PVE/LXC/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 7c81834..41dd22f 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -1850,7 +1850,7 @@ sub vmconfig_apply_pending {
>                              PVE::Network::SDN::Vnets::del_ips_from_mac(
>                                  $old_net->{bridge},
>                                  $old_net->{hwaddr},
> -                                $conf->{name},
> +                                $conf->{hostname},
>                              );
>                              PVE::Network::SDN::Vnets::add_next_free_cidr=
(
>                                  $net->{bridge},