From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B21831FF0AF for ; Fri, 23 Oct 2026 12:22:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0BADC215F5; Fri, 23 Oct 2026 12:22:43 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 23 Oct 2026 12:22:38 +0200 Message-Id: Subject: Re: [PATCH manager] fix #8184: ui: settings: add 'remote resizing' option to noVNC defaults From: "Elias Huhsovitz" To: "Dominik Csapak" , X-Mailer: aerc 0.20.0 References: <20261022140030.176756-1-d.csapak@proxmox.com> In-Reply-To: <20261022140030.176756-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792750958212 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.496 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QEYOAFNWQK7VJ64IIYJKFRLJYYG2HVXI X-Message-ID-Hash: QEYOAFNWQK7VJ64IIYJKFRLJYYG2HVXI X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 1 minor nit inline, otherwise LGTM! Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz On Thu Oct 22, 2026 at 4:00 PM CEST, Dominik Csapak wrote: > This option was introduced after the 'my settings' window was > implemented, so add it. > > Since the number of options would clutter the screen when using radio > buttons, use a standard drop down instead. > > Use '__default__' as default value to stay consistent with other > dropdowns. (The previous 'auto' value was never saved in the browser > local storage anyway). > > While at it, use gettext for the text so they can be translated. > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/Settings.js | 45 ++++++++++----------------------- > 1 file changed, 13 insertions(+), 32 deletions(-) > > diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settin= gs.js > index 77c86c2a..98670865 100644 > --- a/www/manager6/window/Settings.js > +++ b/www/manager6/window/Settings.js > @@ -34,8 +34,8 @@ Ext.define('PVE.window.Settings', { > =20 > var username =3D sp.get('login-username') || Proxmox.Utils.n= oneText; > me.lookupReference('savedUserName').setValue(Ext.String.html= Encode(username)); > - var vncMode =3D sp.get('novnc-scaling') || 'auto'; > - me.lookupReference('noVNCScalingGroup').setValue({ noVNCScal= ingField: vncMode }); > + var vncMode =3D sp.get('novnc-scaling') || '__default__'; > + me.lookupReference('noVNCScaling').setValue(vncMode); > =20 > let summarycolumns =3D sp.get('summarycolumns', 'auto'); > me.lookup('summarycolumns').setValue(summarycolumns); > @@ -394,42 +394,23 @@ Ext.define('PVE.window.Settings', { > title: gettext('noVNC Settings'), > items: [ > { > - xtype: 'radiogroup', > + xtype: 'proxmoxKVComboBox', > fieldLabel: gettext('Scaling mode'), > - reference: 'noVNCScalingGroup', > - height: '15px', // renders faster with value= assigned > - layout: { > - type: 'hbox', > - }, > - items: [ > - { > - xtype: 'radiofield', > - name: 'noVNCScalingField', > - inputValue: 'auto', > - boxLabel: 'Auto', > - }, > - { > - xtype: 'radiofield', > - name: 'noVNCScalingField', > - inputValue: 'scale', > - boxLabel: 'Local Scaling', > - margin: '0 0 0 10', > - }, > - { > - xtype: 'radiofield', > - name: 'noVNCScalingField', > - inputValue: 'off', > - boxLabel: 'Off', > - margin: '0 0 0 10', > - }, > + reference: 'noVNCScaling', > + width: '100%', > + comboItems: [ > + ['__default__', Proxmox.Utils.defaultTex= t], > + ['scale', gettext('Local Scaling')], > + ['remote', gettext('Remote Resizing')], > + ['off', gettext('Off')], nit consistency: The proxmox noVNC settings display 'Scaling mode: Off'. This results in the noVNC Setting 'Scaling mode: None'. We could change it to: ['off', gettext('None')] Since the acutal name 'off', has to stay, so that the URL contains:=20 'resize=3Doff' for the key/value pair. > ], > listeners: { > - change: function (el, { noVNCScalingFiel= d }) { > + change: function (el, value) { > let provider =3D Ext.state.Manager.g= etProvider(); > - if (noVNCScalingField =3D=3D=3D 'aut= o') { > + if (!value || value =3D=3D=3D '__def= ault__') { > provider.clear('novnc-scaling'); > } else { > - provider.set('novnc-scaling', no= VNCScalingField); > + provider.set('novnc-scaling', va= lue); > } > }, > },