From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EF6011FF0B0 for ; Fri, 23 Oct 2026 11:31:21 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5E665215F0; Fri, 23 Oct 2026 11:31:21 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 23 Oct 2026 11:31:17 +0200 Message-Id: Subject: Re: [PATCH qemu-server 4/4] clone disk: bump timeout for querying target volume size to 1 minute From: "Elias Huhsovitz" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20261022093901.52732-1-f.ebner@proxmox.com> <20261022093901.52732-5-f.ebner@proxmox.com> In-Reply-To: <20261022093901.52732-5-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792747877462 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.499 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5DYWCBHYKWAIM26FF5VGEA2MIXN6HWRR X-Message-ID-Hash: 5DYWCBHYKWAIM26FF5VGEA2MIXN6HWRR X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Oct 22, 2026 at 11:38 AM CEST, Fiona Ebner wrote: > Since commit "fix #8209: clone disk: do not ignore failure to query > size of target", failure to query the size of the target volume after > clone is no longer quietly ignored. Bump the timeout to reduce the > likelyhood of harmless timeouts causing a warning. Print a message to > communicate that the query is happening to the user. > > Signed-off-by: Fiona Ebner > --- > src/PVE/QemuServer.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index 4b7351b3..0f8aef6f 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -7931,7 +7931,8 @@ sub clone_disk { > } > =20 > my $result =3D {}; > - my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $newvo= lid, 10) }; > + print "querying size of target volume '$newvolid' after copy..\n"; nit: IMO the message should say: 'after clone...', since we are calling=20 PVE::Storage::vdisk_clone. super nit: i think it should be three dots (...), instead of 2 (..) ;) > + my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $newvo= lid, 60) }; nit: The timeout is inconsistent with the volume_size_info() call on line 7897. There it is still 10 seconds. I am not sure if we can gurantee that querying the source volume is always faster than querying the target volume. general: Tbh I am not sure that a generic timeout is the optimal long-term solution here. I feel like the timeout should be storage specific. E.g., an incrased timeout of 60 seconds for a NFS, but keep the 10 seconds for a local ZFS. But for now, the incrased timeout is fine. > my $err =3D $@; > $err =3D "no size in result" if !$err && !$size; > if ($err) {