From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7583E1FF0B0 for ; Fri, 23 Oct 2026 10:53:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DD3A32161A; Fri, 23 Oct 2026 10:53:06 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 23 Oct 2026 10:53:02 +0200 Message-Id: Subject: Re: [PATCH qemu-server 3/4] clone disk: abort early when failing to query size of source disk From: "Elias Huhsovitz" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20261022093901.52732-1-f.ebner@proxmox.com> <20261022093901.52732-4-f.ebner@proxmox.com> In-Reply-To: <20261022093901.52732-4-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792745582272 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.502 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AMOYQLI2HKYPFVRRU6UDH5DJI3NIP32U X-Message-ID-Hash: AMOYQLI2HKYPFVRRU6UDH5DJI3NIP32U X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Seems sensible! Reviewed-by: Elias Huhsovitz On Thu Oct 22, 2026 at 11:38 AM CEST, Fiona Ebner wrote: > Not all plugin implementations of the volume_size_info() method fail > if there is an error. In particular, the native file-based plugins > use file_size_info() which returns undef upon failure. > > While clone is likely to fail later (e.g. vdisk_alloc() is called with > an undef size), avoid any surprises and fail early with a clean error. > > Signed-off-by: Fiona Ebner > --- > src/PVE/QemuServer.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index 8f062466..4b7351b3 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -7895,6 +7895,7 @@ sub clone_disk { > ); > =20 > $size =3D PVE::Storage::volume_size_info($storecfg, $drive->= {file}, 10); > + die "unable to query size of volume '$drive->{file}'\n" if != $size; > } > $source->{size} =3D $size; > $newvolid =3D PVE::Storage::vdisk_alloc(