From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CB6571FF0C2 for ; Thu, 22 Oct 2026 17:45:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6F2F321672; Thu, 22 Oct 2026 17:45:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 22 Oct 2026 17:45:37 +0200 Message-Id: Subject: Re: [PATCH installer 14/15] tui: network: factor out name pinning into advanced options dialog From: "Lukas Sichert" To: "Christoph Heiss" , References: <20261020112327.641633-1-c.heiss@proxmox.com> <20261020112327.641633-15-c.heiss@proxmox.com> In-Reply-To: <20261020112327.641633-15-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792683937275 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.589 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VB5A2X4ZQ6GIWVU6L4QLKK4TU24S5FJI X-Message-ID-Hash: VB5A2X4ZQ6GIWVU6L4QLKK4TU24S5FJI X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-10-20 13:23, Christoph Heiss wrote: > This dialog can now be easily extended with additional panels for other, > advanced network-related options. > > Signed-off-by: Christoph Heiss > - const PINNING_OPTIONS_BUTTON_NAME: &str =3D "network-pinning-options= -button"; > + const ADVANCED_OPTIONS_BUTTON_NAME: &str =3D "network-pinning-option= s-button"; Nit: If the constant name is changed, it would be nice to update the string value to match=E2=80=94e.g., "advanced-network-options-button".