From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 28F2D1FF0AF for ; Thu, 22 Oct 2026 12:24:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D55A7215DA; Thu, 22 Oct 2026 12:24:34 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 22 Oct 2026 12:24:30 +0200 Message-Id: Subject: Re: [PATCH guest-common 0/2] fix #1964: replication config: add a setting to skip freezing guest filesystems To: "Maximiliano Sandoval" , X-Mailer: aerc 0.20.0 References: <20260706140354.475972-1-m.sandoval@proxmox.com> In-Reply-To: <20260706140354.475972-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792664670174 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.715 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4DV7BKNZLR7B5VFIDF55X6UHQCLZTZTQ X-Message-ID-Hash: 4DV7BKNZLR7B5VFIDF55X6UHQCLZTZTQ X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Jul 6, 2026 at 4:03 PM CEST, Maximiliano Sandoval wrote: > See the second commit message for more information. > > We sneak a change removing an unused Data::Dumper import. > > Tested: > > - Created a VM with ID 101 in a cluster with nodes pve1 and pve2 > - Enabled the QGA service inside the guest > - Created a replication job with > > pve2 $ pvesr create-local-job 101-1 pve1 --skip-freeze-fs 1 --schedule '*= /1' > > - Start the VM > - Ran: pvesr schedule-now 101-1 > - cat /var/log/pve/replicate/101-1 > - checked that it contains the added line in the logs. > > Then repeated the whole thing without specifying --skip-freeze-fs to ensu= re > nothing was broken. > > Maximiliano Sandoval (2): > replication config: remove unused Data::Dumper > fix #1964: replication config: add a setting to skip freezing guest > filesystems > > src/PVE/Replication.pm | 7 +++++++ > src/PVE/ReplicationConfig.pm | 9 ++++++++- > 2 files changed, 15 insertions(+), 1 deletion(-) seems to work as advertised and the code changes seem to fairly straight forward to me. so consider this: Reviewed-by: Shannon Sterz Tested-by: Shannon Sterz one small thing i noticed is that if a node does not have the updated package, editing the replication job through that node's ui will silently drop the new option. however, that is unrelated to this series and a more general issue. editing the job on a node with these changes keeps the option in place as expected.