From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 90E271FF0AF
	for <inbox@lore.proxmox.com>; Thu, 22 Oct 2026 11:29:52 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 1EAD2215D4;
	Thu, 22 Oct 2026 11:29:51 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 22 Oct 2026 11:29:45 +0200
Message-Id: <DMB9FBMKH0SK.15L74DWANQS85@proxmox.com>
Subject: Re: [PATCH pve-ha-manager 09/15] manager: remove obsolete argument
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.22.0-10-g6373ac9d2179-dirty
References: <20261021085932.1196302-1-d.rusovac@proxmox.com>
 <20261021085932.1196302-10-d.rusovac@proxmox.com>
In-Reply-To: <20261021085932.1196302-10-d.rusovac@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792661386009
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.742 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 2TAAIKJ7742K3BEOYQZLWH4OPG5EY3ZA
X-Message-ID-Hash: 2TAAIKJ7742K3BEOYQZLWH4OPG5EY3ZA
X-MailFrom: d.kral@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Good catch, thanks!

On Wed Oct 21, 2026 at 10:59 AM CEST, Dominik Rusovac wrote:
> Respective parameter was removed by [0].
>
> [0] https://lore.proxmox.com/all/20260319164047.642936-4-d.kral@proxmox.c=
om/

Though same here, this should in fact be a Fixes: <commitref>

>
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  src/PVE/HA/Manager.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
> index 5840a76..7a5a685 100644
> --- a/src/PVE/HA/Manager.pm
> +++ b/src/PVE/HA/Manager.pm
> @@ -385,7 +385,7 @@ sub select_service_node {
> =20
>      return $current_node if $node_preference eq 'none' && $pri_nodes->{$=
current_node};
> =20
> -    my $scores =3D $online_node_usage->score_nodes_to_start_service($sid=
, $current_node);
> +    my $scores =3D $online_node_usage->score_nodes_to_start_service($sid=
);
>      my @nodes =3D sort {
>          $scores->{$a} <=3D> $scores->{$b} || $a cmp $b
>      } keys %$pri_nodes;

Otherwise, consider as:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>