From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A82FA1FF0AF for ; Thu, 08 Oct 2026 16:46:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 775B6214BF; Thu, 08 Oct 2026 16:46:40 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 08 Oct 2026 16:46:35 +0200 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH qemu-server v3 11/21] helpers: move version_cmp() helper to pve-common X-Mailer: aerc 0.22.0 References: <20260918160841.128088-1-f.ebner@proxmox.com> <20260918160841.128088-12-f.ebner@proxmox.com> In-Reply-To: <20260918160841.128088-12-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791470795208 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.298 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PXER5KQYHYIZ2C3XJHGEH4M6WEQVFIUT X-Message-ID-Hash: PXER5KQYHYIZ2C3XJHGEH4M6WEQVFIUT X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Noticed that QemuServer::Drive::virtio_win_iso_issue still uses PVE::QemuServer::Helpers::version_cmp. On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > > New in v3. > > src/PVE/QemuServer/Helpers.pm | 30 ++---------------------------- > src/PVE/QemuServer/Machine.pm | 13 +++++-------- > src/PVE/QemuServer/QMPHelpers.pm | 5 +++-- > 3 files changed, 10 insertions(+), 38 deletions(-) > > diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.p= m > index dd17eef5..a39e4abf 100644 > --- a/src/PVE/QemuServer/Helpers.pm > +++ b/src/PVE/QemuServer/Helpers.pm > @@ -228,39 +228,13 @@ sub min_version { > my ($verstr, $major, $minor, $pve) =3D @_; [snip]