From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8D9F61FF0AA for ; Tue, 06 Oct 2026 10:26:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CCDC0213D3; Tue, 06 Oct 2026 10:26:53 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 06 Oct 2026 10:26:47 +0200 Message-Id: Subject: Re: [PATCH guest-common/manager v2 0/3] fix #5713: vzdump: add notification-mode none From: "Lukas Wagner" To: "Erik Fastermann" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260513103109.122977-1-e.fastermann@proxmox.com> In-Reply-To: <20260513103109.122977-1-e.fastermann@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791275207548 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.358 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 26RI33TSVFWLLTZPRZHAIDQUCEOAQSJQ X-Message-ID-Hash: 26RI33TSVFWLLTZPRZHAIDQUCEOAQSJQ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed May 13, 2026 at 12:31 PM CEST, Erik Fastermann wrote: > Optionally disable sending notification mails with the new option > none for notification-mode in vzdump. > > Also includes an optional commit to add this to the ui. > Hey Erik, I'm very sorry for the very late reply, I completely missed this series. If you have any other notification-related patches in the future, feel free to ping me directly. At first, I was a bit hesitant about whether adding a new notification mode would be good idea. The notification mode was always a bit of a hack, one that enabled us to support the legacy notifications (legacy-sendmail, the ones where the user just provides an email address at the backup job invocation/job) alongside the 'new' notification stack based on matchers. I always planned to eventually phase out the legacy mode, but it turned out to be quite a hard problem to automatically migrate the old settings to an equivalent matcher-based config, which is why the 'old' mode is still there. Given this, I was unsure whether I wanted to build on this 'hack', but after giving it some more thought, I think its fine. Even with the legacy-mode phased out, the vzdump CLI should have a way to quickly opt out from notifications (maybe it should even be the default for CLI invocations), and using the `notification-mode` parameter is only fitting I think. Adding it to the UI also seems reasonable to me. I wonder if it would make sense to also add it to backup *jobs*, but there it could make sense to wait until a user actually requests it; we should encourage users to set up proper notification configuration for their jobs, after all. I've actually thought about 'undeprecating' the legacy-mode for a while now, as in quite a few cases is just way simpler to use if all a user wants is to receive an email. The additional code complexity is manageable, so maybe it should just stay as is. Just thinking out aloud here, it's not really decided yet. Acked-by: Lukas Wagner Reviewed-by: Lukas Wagner Tested-by: Lukas Wagner