From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BD82C1FF09B for ; Mon, 28 Sep 2026 11:37:50 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EAA9F2170F; Mon, 28 Sep 2026 11:37:46 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 28 Sep 2026 11:37:38 +0200 Message-Id: Subject: Re: [PATCH installer v2] buildsys: add static version of proxmox-auto-install-assistant From: "Christoph Heiss" To: X-Mailer: aerc 0.22.0 References: <20260623130321.1425355-1-c.heiss@proxmox.com> In-Reply-To: <20260623130321.1425355-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790588258647 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.305 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NJK3AN6OTKNQOKYKUNYPOW6TUXCKDAMQ X-Message-ID-Hash: NJK3AN6OTKNQOKYKUNYPOW6TUXCKDAMQ X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Ping, still applies. On Tue Jun 23, 2026 at 3:00 PM CEST, Christoph Heiss wrote: > This adds a separate debian package to the build, containing a > statically-built version of `proxmox-auto-install-assistant`, as > was suggested by Thomas. > > Similar how we ship a static variant of proxmox-backup-client. > > The binary is placed at /usr/bin/proxmox-auto-install-assistant-static, > with a symlink to it at /usr/bin/proxmox-auto-install-assistant. > > Signed-off-by: Christoph Heiss > --- > Decided to pick this up again, as it recently came up in a discussion. > > lintian reports `shared-library-lacks-prerequisites` [0] for the > resulting package, which seems rather irrelevant (or even bogus) in our > case - thus the override. > > v1: https://lore.proxmox.com/pve-devel/20240816161942.2044889-1-c.heiss@p= roxmox.com/ > > Changes v1 -> v2: > * rebased on latest master > > [0] https://lintian.debian.org/tags/shared-library-lacks-prerequisites > > Makefile | 21 +++++++++++++++++-- > debian/control | 10 +++++++++ > ...xmox-auto-install-assistant-static.install | 1 + > ...roxmox-auto-install-assistant-static.links | 1 + > ...install-assistant-static.lintian-overrides | 1 + > 5 files changed, 32 insertions(+), 2 deletions(-) > create mode 100644 debian/proxmox-auto-install-assistant-static.install > create mode 100644 debian/proxmox-auto-install-assistant-static.links > create mode 100644 debian/proxmox-auto-install-assistant-static.lintian-= overrides > > diff --git a/Makefile b/Makefile > index bb5dc86..f7c25ec 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,4 +1,5 @@ > include /usr/share/dpkg/default.mk > +include /usr/share/rustc/architecture.mk > > PACKAGE =3D proxmox-installer > BUILDDIR ?=3D $(PACKAGE)-$(DEB_VERSION_UPSTREAM) > @@ -6,17 +7,26 @@ BUILDDIR ?=3D $(PACKAGE)-$(DEB_VERSION_UPSTREAM) > DEB=3D$(PACKAGE)_$(DEB_VERSION)_$(DEB_HOST_ARCH).deb > ASSISTANT_DEB=3Dproxmox-auto-install-assistant_$(DEB_VERSION)_$(DEB_HOST= _ARCH).deb > FIRST_BOOT_DEB=3Dproxmox-first-boot_$(DEB_VERSION)_$(DEB_HOST_ARCH).deb > +ASSISTANT_STATIC_DEB=3Dproxmox-auto-install-assistant-static_$(DEB_VERSI= ON)_$(DEB_HOST_ARCH).deb > > -ALL_DEBS =3D $(DEB) $(ASSISTANT_DEB) $(FIRST_BOOT_DEB) > +ALL_DEBS =3D $(DEB) $(ASSISTANT_DEB) $(FIRST_BOOT_DEB) $(ASSISTANT_STATI= C_DEB) > > DSC=3D$(PACKAGE)_$(DEB_VERSION).dsc > > CARGO ?=3D cargo > + > +CARGO_STATIC_TARGET_DIR :=3D target/static > +CARGO_STATIC_RUSTC_FLAGS :=3D -C target-feature=3D+crt-static > +CARGO_STATIC_BUILD_ARGS +=3D --target $(DEB_HOST_RUST_TYPE) --target-dir= $(CARGO_STATIC_TARGET_DIR) > + > ifeq ($(BUILD_MODE), release) > CARGO_BUILD_ARGS +=3D --release > CARGO_COMPILEDIR :=3D target/release > +CARGO_STATIC_BUILD_ARGS +=3D --release > +CARGO_STATIC_COMPILEDIR :=3D $(CARGO_STATIC_TARGET_DIR)/$(DEB_HOST_RUST_= TYPE)/release > else > CARGO_COMPILEDIR :=3D target/debug > +CARGO_STATIC_COMPILEDIR :=3D $(CARGO_STATIC_TARGET_DIR)/$(DEB_HOST_RUST_= TYPE)/debug > endif > > INSTALLER_SOURCES=3D$(shell git ls-files) locale-info.json > @@ -83,6 +93,7 @@ tidy: > > deb: $(DEB) > $(ASSISTANT_DEB): $(DEB) > +$(ASSISTANT_STATIC_DEB): $(DEB) > $(FIRST_BOOT_DEB): $(DEB) > $(DEB): $(BUILDDIR) > cd $(BUILDDIR); dpkg-buildpackage -b -us -uc > @@ -122,7 +133,7 @@ VARLIBDIR=3D$(DESTDIR)/var/lib/proxmox-installer > HTMLDIR=3D$(VARLIBDIR)/html/common > > .PHONY: install > -install: $(INSTALLER_SOURCES) $(COMPILED_BINS) > +install: $(INSTALLER_SOURCES) $(COMPILED_BINS) auto-install-assistant-st= atic > $(MAKE) -C banner install > $(MAKE) -C Proxmox install > $(MAKE) -C proxmox-first-boot install > @@ -134,6 +145,7 @@ install: $(INSTALLER_SOURCES) $(COMPILED_BINS) > install -D -m 755 proxinstall $(DESTDIR)/usr/bin/proxinstall > install -D -m 755 proxmox-low-level-installer $(DESTDIR)/$(BINDIR)/prox= mox-low-level-installer > $(foreach i,$(USR_BIN), install -m755 $(CARGO_COMPILEDIR)/$(i) $(DESTDI= R)$(BINDIR)/ ;) > + install -D -m 755 $(CARGO_STATIC_COMPILEDIR)/proxmox-auto-install-assis= tant $(DESTDIR)$(BINDIR)/proxmox-auto-install-assistant-static > install -D -m 755 checktime $(DESTDIR)/usr/bin/checktime > install -D -m 644 xinitrc $(DESTDIR)/.xinitrc > install -D -m 755 spice-vdagent.sh $(DESTDIR)/.spice-vdagent.sh > @@ -150,6 +162,11 @@ cargo-build: > --package proxmox-post-hook --bin proxmox-post-hook \ > $(CARGO_BUILD_ARGS) > > +.PHONY: auto-install-assistant-static > +auto-install-assistant-static: > + RUSTFLAGS=3D"$(CARGO_STATIC_RUSTC_FLAGS)" \ > + $(CARGO) build --package proxmox-auto-install-assistant $(CARGO_STATIC_= BUILD_ARGS) > + > %-banner.png: %-banner.svg > rsvg-convert -o $@ $< > > diff --git a/debian/control b/debian/control > index 7565c2a..95f695f 100644 > --- a/debian/control > +++ b/debian/control > @@ -77,6 +77,16 @@ Description: Assistant to help with automated installa= tions > installation of a Proxmox project, and preparing a official ISO image t= o use > this answer file. > > +Package: proxmox-auto-install-assistant-static > +Architecture: any > +Recommends: xorriso, ${misc:Depends}, > +Conflicts: proxmox-auto-install-assistant > +Provides: proxmox-auto-install-assistant > +Description: Assistant to help with automated installations - static bui= ld > + Provides a helper that can assist with creating an answer file for a au= tomated > + installation of a Proxmox project, and preparing a official ISO image t= o use > + this answer file. > + > Package: proxmox-first-boot > Architecture: any > Depends: ${misc:Depends}, ${perl:Depends}, > diff --git a/debian/proxmox-auto-install-assistant-static.install b/debia= n/proxmox-auto-install-assistant-static.install > new file mode 100644 > index 0000000..abd2c64 > --- /dev/null > +++ b/debian/proxmox-auto-install-assistant-static.install > @@ -0,0 +1 @@ > +usr/bin/proxmox-auto-install-assistant-static > diff --git a/debian/proxmox-auto-install-assistant-static.links b/debian/= proxmox-auto-install-assistant-static.links > new file mode 100644 > index 0000000..28e003c > --- /dev/null > +++ b/debian/proxmox-auto-install-assistant-static.links > @@ -0,0 +1 @@ > +usr/bin/proxmox-auto-install-assistant-static usr/bin/proxmox-auto-insta= ll-assistant > diff --git a/debian/proxmox-auto-install-assistant-static.lintian-overrid= es b/debian/proxmox-auto-install-assistant-static.lintian-overrides > new file mode 100644 > index 0000000..85efadd > --- /dev/null > +++ b/debian/proxmox-auto-install-assistant-static.lintian-overrides > @@ -0,0 +1 @@ > +proxmox-auto-install-assistant-static: shared-library-lacks-prerequisite= s [usr/bin/proxmox-auto-install-assistant-static]