From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 7E19D1FF0A5
	for <inbox@lore.proxmox.com>; Fri, 04 Sep 2026 14:23:16 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 680F8215EF;
	Fri, 04 Sep 2026 14:23:11 +0200 (CEST)
Content-Type: text/plain; charset=UTF-8
Date: Fri, 04 Sep 2026 14:23:07 +0200
Message-Id: <DL6J1WNYDLHU.BK9K6YPPUTKQ@proxmox.com>
Subject: Re: [PATCH proxmox 10/29] notify: matcher: add
 InlineCalendarMatcher
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Arthur Bied-Charreton" <a.bied-charreton@proxmox.com>, "Lukas Wagner"
 <l.wagner@proxmox.com>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20260709115716.299836-1-l.wagner@proxmox.com>
 <20260709115716.299836-11-l.wagner@proxmox.com>
 <ckq6k6ozmfccevtzfevcs35soxafhmujxwrwlacekq4mkbwjsr@7ka37aj4v7mz>
In-Reply-To: <ckq6k6ozmfccevtzfevcs35soxafhmujxwrwlacekq4mkbwjsr@7ka37aj4v7mz>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1788524583712
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.468 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: PFHYEP3Y35CYNOL43JWGDWVW3CVH4JCO
X-Message-ID-Hash: PFHYEP3Y35CYNOL43JWGDWVW3CVH4JCO
X-MailFrom: l.wagner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Fri Jul 24, 2026 at 8:47 AM CEST, Arthur Bied-Charreton wrote:
>> +impl fmt::Display for DailyDurationWrapper {
>> +    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
>> +        f.write_str(self.as_str())
>> +    }
>> +}
>> +
>> +impl FromStr for DailyDurationWrapper {
>> +    type Err =3D Error;
>> +
>> +    fn from_str(s: &str) -> Result<Self, Error> {
>> +        let daily_duration =3D proxmox_time::parse_daily_duration(s)
> we might wanna trim s here? this fails if s has a leading whitespace,
> which is a code path reachable via the UI (see [0]), and even if/when=20
> that is fixed, i feel like it would be nicer to not fail to parse=20
> because of surrounding whitespace (could also be done at another level
> of the call stack), since that would still be reachable via pvesh etc.
>
> [0] https://lore.proxmox.com/pve-devel/20260709115716.299836-1-l.wagner@p=
roxmox.com/T/#mad9286504ecf2264333be5abe8b9e1f4966aeaeb

I think it's okay to be strict about the format at the API level, but of
course we should ensure that it's not possible to run into this
situation when editing the schedule via the UI.

I managed to reproduce the issue you reported, will try to fix it for
v2.