From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 848F81FF09B for ; Mon, 31 Aug 2026 10:19:01 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 88462212E0; Mon, 31 Aug 2026 10:19:00 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Aug 2026 10:18:54 +0200 Message-Id: Subject: Re: [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module From: "Thomas Ellmenreich" To: "Nicolas Frey" , X-Mailer: aerc 0.20.0 References: <20260722142234.309937-1-n.frey@proxmox.com> In-Reply-To: <20260722142234.309937-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788164321512 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.665 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4EXXNBJ6RSZV5QP4W4FTVHRKIG3GY5KJ X-Message-ID-Hash: 4EXXNBJ6RSZV5QP4W4FTVHRKIG3GY5KJ X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Deduplication is always good. ;) Compared the removed to the new code, although its differently structured, looks to be functionally the same. Reviewed-by: Thomas Ellmenreich On Wed Jul 22, 2026 at 4:22 PM CEST, Nicolas Frey wrote: > As proxmox-pgp crate is now available, use it here and get rid of the > verifier module. > > Also fixed two lifetime related clippy lints in the first patch. > > Changes since v1 (thanks @Erik!): > * correctly order imports in config.rs > * add migration context to the commit message, stating > no functional change was intended > > proxmox-offline-mirror: > > Nicolas Frey (3): > clippy: elide redundant lifetimes > use proxmox-pgp crate to replace verifier helper module > verifier: remove module > > Cargo.toml | 1 + > src/bin/proxmox-offline-mirror-helper.rs | 2 +- > src/config.rs | 33 +---- > src/helpers/mod.rs | 3 - > src/helpers/verifier.rs | 163 ----------------------- > src/medium.rs | 2 +- > src/mirror.rs | 7 +- > 7 files changed, 7 insertions(+), 204 deletions(-) > delete mode 100644 src/helpers/verifier.rs > > > Summary over all repositories: > 7 files changed, 7 insertions(+), 204 deletions(-) > > -- > Generated by murpp 0.12.0