From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 87E661FF0B7 for ; Tue, 25 Aug 2026 15:04:13 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 423C1215E4; Tue, 25 Aug 2026 15:04:13 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 25 Aug 2026 15:04:09 +0200 Message-Id: Subject: Re: [PATCH pve-docs 1/2] qm: pci passthrough: replace obsolete module loading procedure From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Jakob Klocker" , X-Mailer: aerc 0.22.0 References: <20260825114642.278296-1-j.klocker@proxmox.com> <20260825114642.278296-2-j.klocker@proxmox.com> In-Reply-To: <20260825114642.278296-2-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787663019212 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.042 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I23BCEXHMXPB5FQC6MBXL34XDICHZ7AX X-Message-ID-Hash: I23BCEXHMXPB5FQC6MBXL34XDICHZ7AX X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Quickly discussed this with Jakob off-list, as I felt that a reference in the commit message to e.g. the Debian documentation that mentions that the file is now obsolete would have been nice. A quick search did not really turn up anything, though. A comment in /etc/modules notes that it's obsolete, though, so this seems fine IMO. Reviewed-by: Michael K=C3=B6ppl On Tue Aug 25, 2026 at 1:46 PM CEST, Jakob Klocker wrote: > Loading modules by adding them to `/etc/modules` is obsolete and has > been replaced by `/etc/modules-load.d/`. > > Signed-off-by: Jakob Klocker > --- > qm-pci-passthrough.adoc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc > index 00d9478..a188005 100644 > --- a/qm-pci-passthrough.adoc > +++ b/qm-pci-passthrough.adoc > @@ -98,8 +98,8 @@ to the xref:sysboot_edit_kernel_cmdline[kernel commandl= ine]. > =20 > .Kernel Modules > =20 > -You have to make sure the following modules are loaded. This can be achi= eved by > -adding them to `'/etc/modules''. > +Make sure the following modules are loaded by adding them to a file unde= r > +`'/etc/modules-load.d/'`, for example `'/etc/modules-load.d/vfio.conf'`: > =20 > .Mediated devices passthrough > [NOTE] > @@ -467,8 +467,8 @@ with 5th, 6th and 7th generation Intel Core Processor= s, as well as E3 v4, E3 > v5 and E3 v6 Xeon Processors. > =20 > To enable it for Intel Graphics, you have to make sure to load the modul= e > -'kvmgt' (for example via `/etc/modules`) and to enable it on the > -xref:sysboot_edit_kernel_cmdline[Kernel commandline] and add the followi= ng parameter: > +'kvmgt' (for example via `/etc/modules-load.d/`) and to enable it on the > +xref:sysboot_edit_kernel_cmdline[kernel commandline] and add the followi= ng parameter: > =20 > ---- > i915.enable_gvt=3D1