From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7ACF61FF0EA for ; Thu, 13 Aug 2026 16:19:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CED7D217EB; Thu, 13 Aug 2026 16:19:58 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 13 Aug 2026 16:19:53 +0200 Message-Id: Subject: Re: [PATCH proxmox-offline-mirror] fix #7762: wizard: add PDM support From: "Nicolas Frey" To: "Erik Fastermann" , X-Mailer: aerc 0.20.0 References: <20260723092437.93686-1-e.fastermann@proxmox.com> In-Reply-To: <20260723092437.93686-1-e.fastermann@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786630776388 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.547 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TU7W2YANG57IWGJONDBQCZDPI4S2THFL X-Message-ID-Hash: TU7W2YANG57IWGJONDBQCZDPI4S2THFL X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: hi, thanks for the patch! tested the changes on PDM, creating a pdm-no-subscription mirror on a medium and adding a subscription key also worked using the wizard. changes LGTM too, so consider this: Reviewed-by: Nicolas Frey Tested-by: Nicolas Frey On Thu Jul 23, 2026 at 11:24 AM CEST, Erik Fastermann wrote: > Offer Proxmox Datacenter Manager as a distro in the interactive > setup so its repositories can be mirrored offline. > > Signed-off-by: Erik Fastermann Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=3D7762 > --- > src/bin/proxmox-offline-mirror.rs | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/src/bin/proxmox-offline-mirror.rs b/src/bin/proxmox-offline-= mirror.rs > index 90a14a9..7b7a506 100644 > --- a/src/bin/proxmox-offline-mirror.rs > +++ b/src/bin/proxmox-offline-mirror.rs > @@ -27,6 +27,7 @@ use proxmox_offline_mirror_cmds::*; > enum Distro { > Debian, > Pbs, > + Pdm, > Pmg, > Pve, > PveCeph, > @@ -37,6 +38,7 @@ impl Display for Distro { > match self { > Distro::Debian =3D> write!(f, "debian"), > Distro::Pbs =3D> write!(f, "pbs"), > + Distro::Pdm =3D> write!(f, "pdm"), > Distro::Pmg =3D> write!(f, "pmg"), > Distro::Pve =3D> write!(f, "pve"), > Distro::PveCeph =3D> write!(f, "ceph"), > @@ -212,6 +214,7 @@ fn action_add_mirror(config: &SectionConfigData) -> R= esult, Er > let distros =3D &[ > (Distro::Pve, "Proxmox VE"), > (Distro::Pbs, "Proxmox Backup Server"), > + (Distro::Pdm, "Proxmox Datacenter Manager"), > (Distro::Pmg, "Proxmox Mail Gateway"), > (Distro::PveCeph, "Proxmox Ceph"), > (Distro::Debian, "Debian"), > @@ -223,7 +226,12 @@ fn action_add_mirror(config: &SectionConfigData) -> = Result, Er > (Release::Bookworm, "Bookworm"), > (Release::Bullseye, "Bullseye"), > ]; > - let release =3D read_selection_from_tty("Select release", releas= es, Some(0))?; > + let release =3D match dist { > + // PDM (version 1.0 or higher) is only published for Trixie,= so > + // there is nothing to select. > + Distro::Pdm =3D> &Release::Trixie, > + _ =3D> read_selection_from_tty("Select release", releases, S= ome(0))?, > + }; > > let mut add_debian_repo =3D false; > > @@ -354,6 +362,21 @@ fn action_add_mirror(config: &SectionConfigData) -> = Result, Er > (Distro::Pbs, &ProxmoxVariant::Enterprise) =3D> Some= (ProductType::Pbs), > (Distro::Pmg, &ProxmoxVariant::Enterprise) =3D> Some= (ProductType::Pmg), > (Distro::Pve, &ProxmoxVariant::Enterprise) =3D> Some= (ProductType::Pve), > + (Distro::Pdm, &ProxmoxVariant::Enterprise) =3D> { > + // PDM has no dedicated subscription of its own;= its enterprise > + // repository is unlocked by any Basic (or highe= r) PVE or PBS > + // subscription key. > + let products =3D &[(ProductType::Pve, "PVE"), (P= roductType::Pbs, "PBS")]; > + Some( > + read_selection_from_tty( > + "Select subscription (Basic or higher) t= o use \ > + for the PDM enterprise repository", > + products, > + Some(0), > + )? > + .clone(), > + ) > + } > _ =3D> None, > }; >