From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 52DAC1FF0E4 for ; Tue, 11 Aug 2026 09:40:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CB7872155A; Tue, 11 Aug 2026 09:40:07 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 11 Aug 2026 09:40:02 +0200 Message-Id: Subject: superseded: [PATCH storage v2 0/2] fix #7598: qemu-img: increase timeout for image resize From: "Jakob Klocker" To: "Jakob Klocker" , X-Mailer: aerc 0.20.0 References: <20260804090438.58491-1-j.klocker@proxmox.com> In-Reply-To: <20260804090438.58491-1-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786433989630 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.742 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TFDBH4RFWTMRD3EB72TZUIU6546O3E77 X-Message-ID-Hash: TFDBH4RFWTMRD3EB72TZUIU6546O3E77 X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/all/20260811073740.100398-1-j.klock= er@proxmox.com/T/#u On Tue Aug 4, 2026 at 11:04 AM CEST, Jakob Klocker wrote: > Image resizing currently has a timeout of 10 seconds, which can fail > on slow disks and leave the VM in a state where the disk is updated, > but the VM config isn't.=20 > > Since there is no deterministic way to check, with less overhead, if > this is the case, increasing the timeout is the most pragmatic > solution. The resize is only called in a worker context anyway, > therefore this patch series mirrors the ZFS timeout: it increases > the timeout in a worker context to 1 hour; as a fallback for a=20 > non-worker context the timeout stays 10 seconds. > > Additionally there was a minor refactoring: the timeout parameter for > qemu_img_resize was dropped, since the timeout can't be set through > the PVE API and was always hardcoded to 10 seconds. > > Changes since v2 > ----------------- > > - drop the timeout parameter in qemu_img_resize > - increase the timeout instead of querying the disk information > (see v1 for more info. Thanks @Fabian) > > Previous versions > ------------------ > v1: https://lore.proxmox.com/pve-devel/20260603082557.25359-1-j.klocker@p= roxmox.com/t/#u > > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=3D7598 > > > pve-storage: > > Jakob Klocker (2): > qemu-img: drop unused image resize timeout parameter > fix #7598: qemu-img: increase timeout for image resizing in worker > context > > src/PVE/Storage/Common.pm | 9 +++++---- > src/PVE/Storage/LVMPlugin.pm | 2 +- > src/PVE/Storage/Plugin.pm | 2 +- > 3 files changed, 7 insertions(+), 6 deletions(-) > > > Summary over all repositories: > 3 files changed, 7 insertions(+), 6 deletions(-)