From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 955391FF12C for ; Wed, 05 Aug 2026 10:49:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4DB3A217FD; Wed, 05 Aug 2026 10:49:28 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 05 Aug 2026 10:49:23 +0200 Message-Id: From: "Elias Huhsovitz" To: "Jonas Theisen" , Subject: Re: [PATCH pve-manager] Web UI: VM creation Wizard: Pupulate EFI and TPM storage by default X-Mailer: aerc 0.20.0 References: <20260803110534.149543-1-j.theisen@proxmox.com> In-Reply-To: <20260803110534.149543-1-j.theisen@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785919750630 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.104 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 37CTWOOJV5EANQS56OXIZVPQIFYQXZSB X-Message-ID-Hash: 37CTWOOJV5EANQS56OXIZVPQIFYQXZSB X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nice quality of life change! Just one small bug: The "EFI Storage" and "TPM Storage" fields are only populated the first time the options are selected. Repeatedly selecting/unselecting the checkboxes "Addi EFI Disk" and "Add TPM", will not cause the respective storage fields to be populated, reverti= ng=20 to the old behaviour. On Mon Aug 3, 2026 at 1:05 PM CEST, Jonas Theisen wrote: > On VM creation the storage dropdown for EFI and TPM were empty, > while the storage for VM disks was populated by default. > > This commit adds the parameters to the selectors to also populate > the storage for EFI and TPM disks automatically. > > Reported by a forum user in https://forum.proxmox.com/threads/185473/ > > Signed-off-by: Jonas Theisen > --- > www/manager6/qemu/HDEfi.js | 1 + > www/manager6/qemu/HDTPM.js | 1 + > www/manager6/qemu/SystemEdit.js | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js > index 1ae63add..b093a5d9 100644 > --- a/www/manager6/qemu/HDEfi.js > +++ b/www/manager6/qemu/HDEfi.js > @@ -63,6 +63,7 @@ Ext.define('PVE.qemu.EFIDiskInputPanel', { > nodename: me.nodename, > disabled: me.disabled, > hideSize: true, > + autoSelect: me.insideWizard, > }, > { > xtype: 'proxmoxcheckbox', > diff --git a/www/manager6/qemu/HDTPM.js b/www/manager6/qemu/HDTPM.js > index 947e3738..ee51b9ce 100644 > --- a/www/manager6/qemu/HDTPM.js > +++ b/www/manager6/qemu/HDTPM.js > @@ -55,6 +55,7 @@ Ext.define('PVE.qemu.TPMDiskInputPanel', { > nodename: me.nodename, > disabled: me.disabled, > hideSize: true, > + autoSelect: me.insideWizard, > }, > { > xtype: 'proxmoxKVComboBox', > diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEd= it.js > index 299be5f8..458cb493 100644 > --- a/www/manager6/qemu/SystemEdit.js > +++ b/www/manager6/qemu/SystemEdit.js > @@ -137,6 +137,7 @@ Ext.define('PVE.qemu.SystemInputPanel', { > hidden: true, > hideSize: true, > usesEFI: true, > + insideWizard: true, > }, > ], > =20 > @@ -184,6 +185,7 @@ Ext.define('PVE.qemu.SystemInputPanel', { > }, > disabled: true, > hidden: true, > + insideWizard: true, > }, > ], > });