From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9322C1FF125 for ; Mon, 03 Aug 2026 13:50:32 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E852221321; Mon, 03 Aug 2026 13:50:31 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 13:50:27 +0200 Message-Id: Subject: Re: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v3 00/17] GUI Support for Custom Storage Plugins From: "Jakob Klocker" To: "Max R. Carrara" , X-Mailer: aerc 0.20.0 References: <20260727143445.513900-1-m.carrara@proxmox.com> In-Reply-To: <20260727143445.513900-1-m.carrara@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785757817556 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.972 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PSNI462O5QFA4UJEDPGOFTQML6SZZ6VJ X-Message-ID-Hash: PSNI462O5QFA4UJEDPGOFTQML6SZZ6VJ X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I ran the same tests as in the previous version: - adding sshfs plugin over the GUI - editing a plugin over the GUI - removing a plugin over the GUI - checking the output of the new endpoints everything worked as expected. With the changes from the previous versions the code looks good to me. Note that I don't have that much experience with the frontend, but from what I can tell everything looks good. A small side note: there isn't a unified Makefile style across the codebase, which would make sense to have. With that said, thanks for the patches and consider this: Reviewed-by: Jakob Klocker Tested-by: Jakob Klocker On Mon Jul 27, 2026 at 4:34 PM CEST, Max R. Carrara wrote: > GUI Support for Custom Storage Plugins - v3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > Notable Changes Since v2 > ------------------------ > > - Drop the patternProperties RFC patches. > > After some additional consideration, I decided that supporting > patternProperties is out of scope for this series, and probably > something that deserves its own series instead. > > In turn, the 'x-advanced' and 'x-hidden' keys in the plugin property > schema returned by the new API endpoint are now set through two > new hashes in `plugindata()`. This means that each plugin has to > define which properties it considers advanced and which should be > hidden in the UI itself, just like with sensitive properties. > > - Rename the 'sensitive' key that is returned as part of the plugin > property schema by the new API endpoint to 'x-sensitive'. This is done > in order to make it clear that this keyword is not part of our overall > JSON schema, since each plugins' properties' schemas are returned > directly. > > Note that we can still "promote" 'x-sensitive' and have it exist in > the general JSON schema as 'sensitive' at some point in the future, > but that's out of scope for this series. > > - Sort modules in patch #13 (thanks @Jakob for the suggestion!) > > - Update the SSHFS example plugin and make use of the new hashes in > `plugindata()`, `title` keys in `properties()`, and also bump it's API > version, with all changes that are necessary for this. > > Thanks again to everyone who reviewed and/or tested the previous > iterations of this series, as well as to those that provided feedback! > It's much appreciated. > > Previous Versions > ----------------- > > rfc-v1: https://lore.proxmox.com/pve-devel/20250908180058.530119-1-m.carr= ara@proxmox.com/ > rfc-v2: https://lore.proxmox.com/pve-devel/20251121165858.818307-1-m.carr= ara@proxmox.com/ > v1: https://lore.proxmox.com/pve-devel/20260623143402.772452-1-m.carrara@= proxmox.com/ > v2: https://lore.proxmox.com/pve-devel/20260717154943.696411-1-m.carrara@= proxmox.com/ > [SNIP]