From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1D9711FF0E6 for ; Fri, 24 Jul 2026 15:31:47 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E516E214AC; Fri, 24 Jul 2026 15:31:46 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Jul 2026 15:31:38 +0200 Message-Id: Subject: Re: [PATCH proxmox-i18n v2 04/11] make: use long options for msgmerge and msginit To: "Maximiliano Sandoval" X-Mailer: aerc 0.20.0 References: <20260724111257.325867-1-m.sandoval@proxmox.com> <20260724111257.325867-5-m.sandoval@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784899868080 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.175 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QZB2ZBM7LEXEQF7PUGUDPU5OLIPWPB5V X-Message-ID-Hash: QZB2ZBM7LEXEQF7PUGUDPU5OLIPWPB5V X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 24, 2026 at 3:25 PM CEST, Maximiliano Sandoval wrote: > "Shannon Sterz" writes: > >> On Fri Jul 24, 2026 at 3:06 PM CEST, Shannon Sterz wrote: >>> On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote: >>>> For improved readability and being consisten with the other commands. >>>> >>>> Signed-off-by: Maximiliano Sandoval >>>> --- >>>> Makefile | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Makefile b/Makefile >>>> index 1873de31..77fd60a0 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -189,7 +189,7 @@ update_pot: submodule >>>> do_update: >>>> $(MAKE) update_pot >>>> $(MAKE) messages.pot >>>> - for i in $(LINGUAS); do echo -n "$$i: "; msgmerge -s -v $$i.po messa= ges.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done; >>>> + for i in $(LINGUAS); do echo -n "$$i: "; msgmerge --sort-output --ve= rbose $$i.po messages.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done; >>> >>> small question since you are >>> >> >> to complete my thought here: `--sort-output` is deprecated (according to >> `man 1 msgmerge`). since you are touching this code already, maybe we >> want to switch to `--sort-by-file` or stop sorting all together? > > This is on my todo-list but I would not touch it here. Stop using > --sort-output would result in a massive diff after updating the PO > files, just regenerating es.po gives: > > - Replacing --sort-output with --sort-by-file: > 1 file changed, 21451 insertions(+), 21434 deletions(-) > > - Removing --sort-output: > 1 file changed, 16763 insertions(+), 16763 deletions(-) > > And we currently have 32 languages so... > > At some point I have to look into how to do it properly. alright, makes sense, jsut noticed it and thought id mention it. probably best to take a similar approach then to how formatting with tidy or biome was implemented. >>>> >>>> update: >>>> git submodule foreach 'git pull --ff-only origin master' >>>> @@ -199,7 +199,7 @@ stats: >>>> @for i in $(LINGUAS); do echo -n "$$i: "; msgfmt --statistics -o /de= v/null $$i.po; done >>>> >>>> init-%.po: messages.pot >>>> - msginit -i $^ -l $^ -o $*.po --no-translator >>>> + msginit --input $^ --locale $^ --output-file $*.po --no-translator >>>> >>>> .INTERMEDIATE: messages.pot >>>> messages.pot: proxmox-widget-toolkit.pot proxmox-mailgateway.pot pve-= manager.pot proxmox-backup.pot proxmox-datacenter-manager-ui.pot pve-yew-mo= bile-gui.pot pmg-yew-quarantine-gui.pot proxmox-yew-comp.pot proxmox-yew-wi= dget-toolkit.pot