From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D50351FF13A for ; Wed, 22 Jul 2026 13:23:58 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 329D6214BB; Wed, 22 Jul 2026 13:23:58 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 22 Jul 2026 13:23:52 +0200 Message-Id: Subject: Re: [PATCH cluster v2 2/2] fix #5475: configurable window title From: "Thomas Ellmenreich" To: "Elias Huhsovitz" , X-Mailer: aerc 0.20.0 References: <20260720100329.118508-1-t.ellmenreich@proxmox.com> <20260720100329.118508-3-t.ellmenreich@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784719405080 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.128 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPMTUQULBZB4Q2IXSQ6ZGLG4OJY2FNFR X-Message-ID-Hash: WPMTUQULBZB4Q2IXSQ6ZGLG4OJY2FNFR X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for your review, I'm addressing the issues on the other patch right now! On Wed Jul 22, 2026 at 12:38 PM CEST, Elias Huhsovitz wrote: [snip] >> +my $ui_settings_format =3D { >> + 'title' =3D> { > nit: The 'title' in the ui_settings_format might be a bit vagaue, since t= he > format might be used in future UI settings. Perhaps some thing like > 'page-title' or 'tab-title' might be better suited. But this is very > pedantic of me. For this one, I had it as 'window-title' before, but with the suggestion to create the 'ui-settings' format string, @Thomas Lamprecht [1] also mentioned changing the 'window-title' name to just 'title' which I found fitting. [1]: https://lore.proxmox.com/pve-devel/3f04e2b9-d39f-4604-b169-c3ae530256a= f@proxmox.com/ [snip]