From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7CAA41FF13A for ; Wed, 22 Jul 2026 12:38:32 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8FD48214BE; Wed, 22 Jul 2026 12:38:31 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 22 Jul 2026 12:38:26 +0200 Message-Id: Subject: Re: [PATCH cluster v2 2/2] fix #5475: configurable window title From: "Elias Huhsovitz" To: "Thomas Ellmenreich" , X-Mailer: aerc 0.20.0 References: <20260720100329.118508-1-t.ellmenreich@proxmox.com> <20260720100329.118508-3-t.ellmenreich@proxmox.com> In-Reply-To: <20260720100329.118508-3-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784716679575 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 52YOF2VNOHPRTOFD6TRCTYJOQ27KLC24 X-Message-ID-Hash: 52YOF2VNOHPRTOFD6TRCTYJOQ27KLC24 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The new setting matches the existing format well. See 1 nit below.=20 That being said: Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz On Mon Jul 20, 2026 at 12:03 PM CEST, Thomas Ellmenreich wrote: > Added a new 'ui-settings' format string to the datacenter.cfg. Currently > only contains a 'title' option to determine the window title of the > nodes browser tab. > > Signed-off-by: Thomas Ellmenreich > --- > src/PVE/DataCenterConfig.pm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..751d8ed 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -344,6 +344,16 @@ my $user_tag_privs_format =3D { > }, > }; > =20 > +my $ui_settings_format =3D { > + 'title' =3D> { nit: The 'title' in the ui_settings_format might be a bit vagaue, since the format might be used in future UI settings. Perhaps some thing like 'page-title' or 'tab-title' might be better suited. But this is very pedantic of me. > + optional =3D> 1, > + type =3D> 'string', > + enum =3D> ['node-and-cluster', 'fqdn'], > + description =3D> > + "Define the text displayed in the browser tab title for all = nodes in this cluster.", > + }, > +}; > + > my $datacenter_schema =3D { > type =3D> "object", > additionalProperties =3D> 0, > @@ -436,6 +446,12 @@ my $datacenter_schema =3D { > # FIXME: remove 'applet' with 9.0 (add pve8to9 check!) > enum =3D> ['applet', 'vv', 'html5', 'xtermjs'], > }, > + 'ui-settings' =3D> { > + optional =3D> 1, > + type =3D> "string", > + format =3D> $ui_settings_format, > + description =3D> "For cluster wide ui settings.", > + }, > email_from =3D> { > optional =3D> 1, > type =3D> 'string', > @@ -618,6 +634,10 @@ sub parse_datacenter_config { > $res->{'tag-style'} =3D parse_property_string($tag_style_format,= $tag_style); > } > =20 > + if (my $ui_settings =3D $res->{'ui-settings'}) { > + $res->{'ui-settings'} =3D parse_property_string($ui_settings_for= mat, $ui_settings); > + } > + > if (my $user_tag_privs =3D $res->{'user-tag-access'}) { > $res->{'user-tag-access'} =3D parse_property_string($user_tag_pr= ivs_format, $user_tag_privs); > =20 > @@ -711,6 +731,11 @@ sub write_datacenter_config { > $cfg->{'tag-style'} =3D PVE::JSONSchema::print_property_string($= tag_style, $tag_style_format); > } > =20 > + if (ref(my $ui_settings =3D $cfg->{'ui-settings'})) { > + $cfg->{'ui-settings'} =3D > + PVE::JSONSchema::print_property_string($ui_settings, $ui_set= tings_format); > + } > + > if (ref(my $user_tag_privs =3D $cfg->{'user-tag-access'})) { > if (my $user_tags =3D $user_tag_privs->{'user-allow-list'}) { > $user_tag_privs->{'user-allow-list'} =3D join(';', sort $use= r_tags->@*);