From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 84ACF1FF150
	for <inbox@lore.proxmox.com>; Mon, 06 Jul 2026 15:02:58 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 43F0B21464;
	Mon, 06 Jul 2026 15:02:58 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 06 Jul 2026 15:02:23 +0200
Message-Id: <DJRIBA2ND9IK.RF8V4M2BOE6B@proxmox.com>
From: "Daniel Kral" <d.kral@proxmox.com>
To: "David Riley" <d.riley@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-common v2 08/10] tools: add helpers for version
 comparison
X-Mailer: aerc 0.21.0-147-g43ac7b685014-dirty
References: <20260626131035.112374-1-d.riley@proxmox.com>
 <20260626131035.112374-9-d.riley@proxmox.com>
In-Reply-To: <20260626131035.112374-9-d.riley@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783342936994
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.018 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: U2IAQDQP2D4ZB543ZILJEN5SWVFMV2FM
X-Message-ID-Hash: U2IAQDQP2D4ZB543ZILJEN5SWVFMV2FM
X-MailFrom: d.kral@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote:
> Move 'version_cmp' and 'pvecfg_min_version' over from qemu-server, to
> make them more accessible.
>
> Originally-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Originally-by: Alexandre Derumier <aderumier@odiso.com>
> Signed-off-by: David Riley <d.riley@proxmox.com>

Reviewed-by: Daniel Kral <d.kral@proxmox.com>