From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3EA931FF141 for ; Tue, 30 Jun 2026 13:39:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 065672141C; Tue, 30 Jun 2026 13:39:08 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 30 Jun 2026 13:38:35 +0200 Message-Id: To: "Lukas Sichert" , Subject: Re: [PATCH manager v7 3/4] fix #7339: lvmthick: ui: add UI option to free storage From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.21.0 References: <20260616101323.24981-1-l.sichert@proxmox.com> <20260616101323.24981-4-l.sichert@proxmox.com> In-Reply-To: <20260616101323.24981-4-l.sichert@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782819503331 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JX3XVGOKZPC6XXMLW65WNJ222ORN4QTJ X-Message-ID-Hash: JX3XVGOKZPC6XXMLW65WNJ222ORN4QTJ X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tested this on my local setup. As suggested in my comment on your other patch, I think UX-wise it'd be nice if there was a check for discard support when the checkbox is set. It's just something I noticed while testing the UI side, but other than that this lgtm. Reviewed-by: Michael K=C3=B6ppl Tested-by: Michael K=C3=B6ppl On Tue Jun 16, 2026 at 12:13 PM CEST, Lukas Sichert wrote: > The storage commit 'fix #7339: lvm: add discard action for removed > volumes' adds backend support to discard allocated space of a VM disk on > a SAN, when a VM is deleted. The backend checks whether to use this [snip]