From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BF59A1FF138 for ; Mon, 15 Jun 2026 09:56:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 23BB8AFFA; Mon, 15 Jun 2026 09:56:05 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 15 Jun 2026 09:55:27 +0200 Message-Id: To: "Shan Shaji" , Subject: Re: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function From: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20260421121212.218008-1-s.shaji@proxmox.com> In-Reply-To: <20260421121212.218008-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781510074042 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.150 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: W7OMQYWXUUTGYR7WFAVY4MU7NCVMZXJL X-Message-ID-Hash: W7OMQYWXUUTGYR7WFAVY4MU7NCVMZXJL X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gentle ping, this still applies in master.=20 On Tue Apr 21, 2026 at 2:12 PM CEST, Shan Shaji wrote: > While placing the ACME certificate order using the Active24 plugin, > the request was failing [0]. This was because, `_json_decode` function > was referenced inside the dns_active24.sh file but was never defined > in the `proxmox-acme` script.To fix it, the missing function was added > by referencing the implementation from the acme.sh [1] script. > > - [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-js= on_decode-command-not-found.182899/ > - [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912