From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 245561FF146 for ; Tue, 26 May 2026 15:58:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57510CFF; Tue, 26 May 2026 15:58:02 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 15:57:27 +0200 Message-Id: Subject: Re: [PATCH-SERIES storage/qemu-server v3 00/11] fix #7094: external snapshot delete: ensure commit target is large enough From: "Lukas Sichert" To: "Fiona Ebner" , References: <20260519110646.25060-1-f.ebner@proxmox.com> In-Reply-To: <20260519110646.25060-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779803822884 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.421 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VY4LV627DJSMM6YSYAQ2QEWZCNEX5KLA X-Message-ID-Hash: VY4LV627DJSMM6YSYAQ2QEWZCNEX5KLA X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-05-19 13:06, Fiona Ebner wrote: > Changes in v3: > * rebase on latest master, need to bump APIAGE+VER one more > > Changes in v2: > * rebase on latest master. > > For LVM storages using 'snapshot-as-volume-chain', it's necessary to > ensure that the size for the LV of the target snapshot volume is large > enough before doing a commit operation. This affects both the offline > and the online case, which have different code paths. > > To make this possible via the storage (plugin) API, the > volume_resize() method gains a new 'snapname' parameter and the > 'virtual-size' of each snapshot is returned in the result of > volume_snapshot_info(). > > The series also adds documentation for volume_resize() and > volume_snapshot_info(), the latter of which is a bit hairy, since it > was previously only used for ZFS replication and then re-used for > snapshot-as-volume-chain which returns quite different information. > It's not too bad though. > > Lastly, there's some cleanups for the volume_snapshot_info() method. > > > Storage plugin API age and version are bumped in the series. > Dependency bump from qemu-server to libpve-storage-perl needed! I reproduced the old offline failure on an lvm storage with snapshot-as-volume-chain 1, backed by a thinly provisioned SAN LUN. The repro was: create a first external snapshot, resize the active disk, write data into the newly added region, then delete that first snapshot. With the old code, the offline delete path fails with qemu-img commit returning No space left on device. I also tested the live path with the old code using the same general setup. I did not get the same No space left on device failure there; instead the block job was cancelled in my environment, so I could not reproduce the live failure cleanly. With the patch installed, the offline case succeeds as expected because the target snapshot LV is resized before commit. I also checked lvmthin for regressions, and normal qm snapshot, qm resize, and qm delsnapshot behavior still works there. Tested-by: Lukas Sichert Reviewed-by: Lukas Sichert