From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 988941FF141 for ; Tue, 19 May 2026 17:17:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D0EDC7EA; Tue, 19 May 2026 17:16:57 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 19 May 2026 17:16:20 +0200 Message-Id: Subject: Re: [PATCH pve-manager] ui: add online help link for prefix lists and route maps To: "Christian Ebner" , X-Mailer: aerc 0.20.0 References: <20260519122915.308863-1-c.ebner@proxmox.com> In-Reply-To: <20260519122915.308863-1-c.ebner@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779203767229 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MIAC4TWTQCSXOCIJ2SBBQMFEHB226KFU X-Message-ID-Hash: MIAC4TWTQCSXOCIJ2SBBQMFEHB226KFU X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 19, 2026 at 2:29 PM CEST, Christian Ebner wrote: > These have several config options which are worth to be easily looked > up by directly providing the link to the docs. > > Signed-off-by: Christian Ebner > --- > www/manager6/sdn/PrefixListPanel.js | 2 ++ > www/manager6/sdn/RouteMapPanel.js | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/Prefi= xListPanel.js > index d8ce3db8..d678356c 100644 > --- a/www/manager6/sdn/PrefixListPanel.js > +++ b/www/manager6/sdn/PrefixListPanel.js > @@ -45,6 +45,8 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', { > extend: 'Proxmox.window.Edit', > mixins: ['Proxmox.Mixin.CBind'], > > + onlineHelp: 'pvesdn_config_prefix_lists', > + > // TRANSLATORS: Refers to an FRR prefix list, some languages may pre= fer to > // keep "prefix list" as-is: > // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list > diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMa= pPanel.js > index 46f243fb..25630d8c 100644 > --- a/www/manager6/sdn/RouteMapPanel.js > +++ b/www/manager6/sdn/RouteMapPanel.js > @@ -709,6 +709,8 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', { > // https://docs.frrouting.org/en/latest/routemap.html > subject: gettext('Route Map Entry'), > > + onlineHelp: 'pvesdn_config_route_maps', > + > initComponent: function () { > let me =3D this; > me.method =3D me.isCreate ? 'POST' : 'PUT'; ah sorry somehow missed that and send a similar patch now [1]. however, yours add help buttons to the edit/add dialogs, whereas mine affects the top right "Help" button in the panels. imo it could still make sense to apply both here. not applying mine would mean that those "Help" buttons would essentially become a second "Documentation" button. [1]: https://lore.proxmox.com/pve-devel/20260519150415.334856-1-s.sterz@pro= xmox.com/T/#m59a50d54e8b5df41a3dd9ea0ecbe73ba9b9dc41a