From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D6A381FF13A for ; Wed, 13 May 2026 14:06:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E970B56A; Wed, 13 May 2026 14:06:06 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 13 May 2026 14:05:58 +0200 Message-Id: To: "Dominik Rusovac" , Subject: Re: [PATCH-SERIES ha-manager/manager v2 0/3] fix #7557: introduce 'auto-rebalance' property From: "Daniel Kral" X-Mailer: aerc 0.21.0-136-gdb9fe9896a79-dirty References: <20260513104657.1105858-1-d.rusovac@proxmox.com> In-Reply-To: <20260513104657.1105858-1-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778673954931 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: CCDFD3KFDTBR5LXUIZDOUFFVGI75JUQO X-Message-ID-Hash: CCDFD3KFDTBR5LXUIZDOUFFVGI75JUQO X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed May 13, 2026 at 12:46 PM CEST, Dominik Rusovac wrote: > # TL;DR > Add 'auto-rebalance' property to HA resources config, which gives users > control over which HA resources may be moved by dynamic CRS during > automatic rebalancing. > > # Details > The 'auto-rebalance' flag is set to true by default. As requested by [0], > disabling 'auto-rebalance' for some HA resource, say vm:100, means that v= m:100 > will be disregarded as a migration candidate during auto-rebalancing. Any= HA > resource with a positive affinity for vm:100 will be disregarded too. > > # Summary of Changes > This series: > - introduces property to control whether an HA resource may be migrated d= uring > automatic rebalancing; > - adds corresponding flag to PVE UI. > > # Refs > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3D7557 > > NOTE: changes since v1 are given per patch in notes Thanks for the quick v2, works as expected (tested the same as in the previous review with some resource bundles clearing/setting auto-rebalance for a bunch of HA resources)! Consider the series as: Reviewed-by: Daniel Kral Tested-by: Daniel Kral