From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4C0D21FF146 for ; Tue, 12 May 2026 13:56:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E2ED10BE1; Tue, 12 May 2026 13:56:24 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 May 2026 13:55:45 +0200 Message-Id: Subject: Re: [PATCH pve-ha-manager 2/3] manager: set service config value in self From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260511155734.149101-1-d.rusovac@proxmox.com> <20260511155734.149101-3-d.rusovac@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778586833885 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.354 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: K2XLK2JWMTW3X4IWEB36CXBCBNKQSFUU X-Message-ID-Hash: K2XLK2JWMTW3X4IWEB36CXBCBNKQSFUU X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: thx for taking the time, will resolve the nits in v2 On Tue May 12, 2026 at 11:06 AM CEST, Daniel Kral wrote: > Looks good to me, left a few nits inline, with those resolved consider > this patch as: > > Reviewed-by: Daniel Kral > > On Mon May 11, 2026 at 5:57 PM CEST, Dominik Rusovac wrote: >> This is in preparation for the follow-up patch. >> >> Reading the value of 'auto-rebalance'-flag in the service config of an >> HA resource is required to perform proper resource bundling. >> >> Signed-off-by: Dominik Rusovac >> --- >> src/PVE/HA/Manager.pm | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) [snip]