From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4540A1FF142 for ; Tue, 05 May 2026 09:51:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 623F218E27; Tue, 5 May 2026 09:51:09 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 May 2026 09:51:04 +0200 Message-Id: Subject: Re: applied: [PATCH-SERIES docs/manager v2 00/19] crs docs updates + load balancer ui and docs followup From: "Daniel Kral" To: "Thomas Lamprecht" , X-Mailer: aerc 0.21.0-136-gdb9fe9896a79-dirty References: <20260415091635.162224-1-d.kral@proxmox.com> <177790350180.2412829.2493019580410985677.b4-ty@b4> In-Reply-To: <177790350180.2412829.2493019580410985677.b4-ty@b4> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777967358415 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Y65UESESWZF4OL4FXTLILFOSN55ETF2L X-Message-ID-Hash: Y65UESESWZF4OL4FXTLILFOSN55ETF2L X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon May 4, 2026 at 4:05 PM CEST, Thomas Lamprecht wrote: > On Wed, 15 Apr 2026 11:15:27 +0200, Daniel Kral wrote: >> changes since v1 (thanks @Shannon, @Michael and @Dominik!): >> - rebase on master >> - fix typos and reword some bits as suggested in the review >>=20 >> I didn't go for the removal of disabled fields out of UX and consistency >> and didn't go for adding the pvesh command because of the text flow, see >> patches #5 and #7 for more information. >>=20 >> [...] > > Applied, with some wording/grammar fixes squashed in, thanks! > > I also added the missing "ha_manager_crs" prefix to three section referen= ces, > as while I'd be fine with having some generic non-ha references now alrea= dy, > this still should get some namespace prefix (e.g., just "crs") and we can= still > do that later, when CRS is actually available for non-ha. Yeah, I was a little pedantic about the existing default permalinks added to the headings, so existing permalinks aren't broken for those, but I wonder how many links there exist that point exactly at the scheduler modes. I had a read over the adapted patches and the changes look good, thanks!