From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3EC961FF136 for ; Mon, 04 May 2026 11:38:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEB7E17CAB; Mon, 4 May 2026 11:38:03 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 04 May 2026 11:37:27 +0200 Message-Id: To: =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH cluster/docs/manager v3 0/8] add warning messages for high token timeouts in clusters From: "Lukas Sichert" References: <20260427170548.307698-1-m.koeppl@proxmox.com> In-Reply-To: <20260427170548.307698-1-m.koeppl@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777887342983 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.610 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WOZQ2R6LWWLGBJNWOGRTLJFDHFFHKB35 X-Message-ID-Hash: WOZQ2R6LWWLGBJNWOGRTLJFDHFFHKB35 X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: What I have tested: - a small selection of links using 'onlineHelp' still work - the new link to documentation in the 'Join Information' field in the ui using the 'get_help_link' works -the correct messages are displayed in the cli and ui if the `token_coefficient` is high enough Tested-by: Lukas Sichert On 2026-04-27 19:05, Michael K=C3=B6ppl wrote: > This patch series introduces warnings informing users about high token > timeouts in their clusters. A recent change [0] lowered the token > coefficient for clusters and allowed adapting it. However, this change > only affects new clusters. As described in [1], users with existing > cluster should be informed about the high token timeouts in their > configurations and what they can do to alleviate this problem. > > Thus, warnings are added to the `pvecm status` command as well as to the > cluster join info dialog in the web UI. The warning in the web UI warns > users about the effect adding another node would have to allow them to > make an informed change before adding another node. > > changes since v2 (thanks to @Lukas and @Friedrich for the feedback): > - use "lowering" instead of "changing" for the warning strings > - replace leftover hard-coded PVE docs link with `man pvecm` > - update descriptions of timeout_warning_level and expected_timeout > params such that they say "membership recovery timeout", to more > clearly state which timeout this is about > - update function names for get_timeout_warning_level and > get_timeout_warning to > calculate_membership_recovery_timeout_warning_level and > calculate_membership_recovery_timeout_warning respectively > > changes since v1 (thanks to @Friedrich for the feedback on v1): > - add pve-docs patch to allow using get_help_link to directly link to > an anchor in the local documentation (then used to link to the section > on changing the token coefficient) > - add pve-docs patch to define explicit anchor for the "Changing the > Token Coefficient" section > - add pve-docs patch extending the section for Changing the Token > Coefficient slightly, informing users of the potential warning > messages in the pvecm status output > - change the threshold for "strongly recommend" from 50s to 45s as > suggested by @Friedrich > - adapted the name of calculate_total_timeout to > calculate_membership_recovery_timeout > - adapted commit messages for preparatory pve-manager patch (no > functional changes intended) > - moved the warning message in pvecm from `pvecm nodes` to `pvecm status` > - replaced the URL in the pvecm warning message with a reference to the > pvecm man pages > - link to local documentation in ClusterEdit.js > > > pve-docs: > > Michael K=C3=B6ppl (3): > asciidoc-pve: allow linking sections with get_help_link > pvecm: add explicit anchor for token coefficient section > pvecm: add info about warnings regarding token coefficient > > pvecm.adoc | 6 ++++++ > scripts/asciidoc-pve.in | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > > pve-cluster: > > Michael K=C3=B6ppl (3): > add functions to determine warning level for high token timeouts > pvecm: warn users of high token timeouts when using status command > api: add token timeout and warning level to cluster join info > > src/PVE/API2/ClusterConfig.pm | 24 +++++++++++++++++ > src/PVE/CLI/pvecm.pm | 12 +++++++++ > src/PVE/Corosync.pm | 50 +++++++++++++++++++++++++++++++++++ > 3 files changed, 86 insertions(+) > > > pve-manager: > > Michael K=C3=B6ppl (2): > ui: cluster info: move initialization of items to initComponent > ui: cluster info: warn users of high token timeout in join info > > www/manager6/dc/Cluster.js | 4 + > www/manager6/dc/ClusterEdit.js | 141 ++++++++++++++++++++++----------- > 2 files changed, 97 insertions(+), 48 deletions(-) > > > Summary over all repositories: > 7 files changed, 190 insertions(+), 49 deletions(-) > > --=20 > Generated by murpp 0.11.0