From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 86C0B1FF145 for ; Fri, 24 Apr 2026 14:24:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BF3517D86; Fri, 24 Apr 2026 13:59:39 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Apr 2026 13:59:32 +0200 Message-Id: Subject: Re: [PATCH-SERIES qemu-server v3 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain From: "Lukas Sichert" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20260423093753.43199-1-f.ebner@proxmox.com> In-Reply-To: <20260423093753.43199-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777031882142 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.661 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: EAAVVBSNXRBLVY77SGEPHOS4RJEJLFQP X-Message-ID-Hash: EAAVVBSNXRBLVY77SGEPHOS4RJEJLFQP X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I went through the code and the changes look good overall, just two small nits: The git history is somewhat confusing. Changes introduced in one commit are modified again in later commits. This would be completely fine if it ensured that the codebase remains in a consistent state after each commit, but as already discussed in [1], this is not always the case. That said, the series works correctly once applied in full. Also, in my opinion, 'qsd_qmp_peer' would be a better name than 'qsd_peer' to make it explicit that this refers to a QMP peer and to keep naming consistent with 'vm_qmp_peer'. [1] lore.proxmox.com/pve-devel/DI0L56K45KJK.1G3MBGPZI2KJV@proxmox.com/T/#m7= e7ffe8240f4092755e27c6072e0e27ffcdd96b5