From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 49B851FF140 for ; Fri, 24 Apr 2026 10:54:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0343103D4; Fri, 24 Apr 2026 10:54:18 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Apr 2026 10:53:44 +0200 Message-Id: To: "Arthur Bied-Charreton" , "Dominik Csapak" Subject: Re: [PATCH proxmox-widget-toolkit v4 11/24] utils: Add OAuth2 flow handlers X-Mailer: aerc 0.20.0 References: <20260421115957.402589-1-a.bied-charreton@proxmox.com> <20260421115957.402589-12-a.bied-charreton@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777020734160 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DTCO5MFOYOSX2YI5G6GB64UFXGHIELZL X-Message-ID-Hash: DTCO5MFOYOSX2YI5G6GB64UFXGHIELZL X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Apr 24, 2026 at 10:44 AM CEST, Arthur Bied-Charreton wrote: > On Thu, Apr 23, 2026 at 02:24:32PM +0200, Shannon Sterz wrote: >> On Tue Apr 21, 2026 at 1:59 PM CEST, Arthur Bied-Charreton wrote: -->8 snip 8<-- >> also if i remember correctly there was an issue with using the async >> fetch api in extjs, maybe @Dominik Csapak could take a look if this is >> fine here. >> > > I had a talk with Dominik off-list, async calls are indeed often an > issue in Ext.js, because it does not detect async functions, meaning it > may treat functions defined as async the same way it would treat > synchronous ones. This can lead to issues where e.g. a function that is > expected to be sync and return a string returns a promise instead, > breaking Ext.js' handling of the return value. > > This is however not an issue here, because this is only called in the > SmtpEditPanel's Authorize button handler, which is defined as async and > expected by Ext.js to be async, so it will be properly awaited. ah makes sense, sorry i couldn't remember the details here anymore, thanks for looking into it! -->8 snip 8<--