From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 289E01FF13F for ; Thu, 23 Apr 2026 15:59:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF1771A40E; Thu, 23 Apr 2026 15:59:35 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Apr 2026 15:59:01 +0200 Message-Id: Subject: Re: [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Lukas Sichert" , =?utf-8?q?Michael_K=C3=B6ppl?= , X-Mailer: aerc 0.21.0 References: <20260420164314.370023-1-m.koeppl@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776952652940 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ICWZSV3C54Q3J5DGYCHHWS5RR73YDDO3 X-Message-ID-Hash: ICWZSV3C54Q3J5DGYCHHWS5RR73YDDO3 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for having a look at this and testing! On Wed Apr 22, 2026 at 3:06 PM CEST, Lukas Sichert wrote: > I applied the patches and tested: > > - a small selection of links using `onlineHelp` still work > - the new link using `get_help_link` jumps to the correct section > - the correct messages are displayed in the cluster and UI if the > `token_coefficient` is high enough > > One additional small nit not directly related to the changes in this > commit, but closely related: the documentation does not mention which > variable needs to be set for the token coefficient. While the name > `token_coefficient` is quite intuitive, I think it would still be good > to mention it explicitly, so one knows what to search for in the > manpages. @Friedrich is already working on that. Still, thanks for pointing it out! > > Since my comments are mostly minor, feel free to include my `Tested-by` > in v3. > > Tested-by: Lukas Sichert [snip]