From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 94AF61FF13B for ; Wed, 22 Apr 2026 14:43:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FAFE1E206; Wed, 22 Apr 2026 14:43:20 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 22 Apr 2026 14:43:16 +0200 Message-Id: Subject: Re: [PATCH cluster v2 6/8] api: add token timeout and warning level to cluster join info From: "Lukas Sichert" To: =?utf-8?q?Michael_K=C3=B6ppl?= , References: <20260420164314.370023-1-m.koeppl@proxmox.com> <20260420164314.370023-7-m.koeppl@proxmox.com> In-Reply-To: <20260420164314.370023-7-m.koeppl@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776861708716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.845 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5QMRWBJZICGLXV2V5H53PX7TBL5HQ76Y X-Message-ID-Hash: 5QMRWBJZICGLXV2V5H53PX7TBL5HQ76Y X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-04-20 18:43, [=3D?utf-8?q?Michael_K=3DC3=3DB6ppl?=3D ] wrote: > The token timeout in seconds and the warning level provide additional > information for users regarding the expected token timeout in seconds > after adding an additional node and whether changing the token > coefficient is recommended. > > Signed-off-by: Michael K=C3=B6ppl > --- > src/PVE/API2/ClusterConfig.pm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/src/PVE/API2/ClusterConfig.pm b/src/PVE/API2/ClusterConfig.p= m > index bbed40e..5739e4c 100644 > --- a/src/PVE/API2/ClusterConfig.pm > +++ b/src/PVE/API2/ClusterConfig.pm > @@ -571,6 +571,18 @@ __PACKAGE__->register_method({ > preferred_node =3D> get_standard_option('pve-node'), > totem =3D> { type =3D> 'object' }, > config_digest =3D> { type =3D> 'string' }, > + expected_timeout =3D> { > + type =3D> 'number', > + description =3D> > + "Expected total timeout (in seconds) if an additiona= l node is added.", > + optional =3D> 1, > + }, > + timeout_warning_level =3D> { > + type =3D> 'string', > + description =3D> "Warning level for the expected total t= imeout.", > + optional =3D> 1, > + enum =3D> ['optimize', 'change-recommended', 'change-str= ongly-recommended'], > + }, > }, > }, As discussed in [1] new API variables use a dash instead of an underscore. In this file and as far as I have seen in the complete repo this stye has not been used yet. Maybe somebody with more knowledge about the styleguide can give their opinion here.=20 > code =3D> sub { > @@ -599,12 +611,22 @@ __PACKAGE__->register_method({ > $node->{pve_addr} =3D scalar(PVE::Cluster::remote_node_ip($n= ame)); > } > =20 > + # Total timeout if additional node is added > + my $total_timeout_secs =3D PVE::Corosync::calculate_membership_r= ecovery_timeout( > + $totem_cfg, > + scalar(keys %$nodelist) + 1, > + ); > + > + my $warning_level =3D PVE::Corosync::get_timeout_warning_level($= total_timeout_secs); > + > my $res =3D { > nodelist =3D> [values %$nodelist], > preferred_node =3D> $nodename, > totem =3D> $totem_cfg, > config_digest =3D> $corosync_config_digest, > + expected_timeout =3D> $total_timeout_secs, > }; > + $res->{timeout_warning_level} =3D $warning_level if defined($war= ning_level); > =20 > return $res; > }, > --=20 > 2.47.3 [1] https://lore.proxmox.com/all/DHA3CMV4VBMI.14WCK95P7U5AW@proxmox.com/