From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9201A1FF13E for ; Fri, 17 Apr 2026 11:11:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A18BB1AF9A; Fri, 17 Apr 2026 11:11:39 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Apr 2026 11:11:05 +0200 Message-Id: To: "Fiona Ebner" , "Lukas Wagner" , , Subject: Re: [PATCH pve-storage 7/7] api: add /nodes//storage//identity route From: "Lukas Wagner" X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260415115817.348947-1-l.wagner@proxmox.com> <20260415115817.348947-8-l.wagner@proxmox.com> <262d3355-b8ec-470c-8fed-32a7b151fee4@proxmox.com> In-Reply-To: <262d3355-b8ec-470c-8fed-32a7b151fee4@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776416985543 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XY74SIJUZUGXTEUGNYXK4A5HKLZWAJLW X-Message-ID-Hash: XY74SIJUZUGXTEUGNYXK4A5HKLZWAJLW X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Apr 17, 2026 at 10:54 AM CEST, Fiona Ebner wrote: > Am 15.04.26 um 1:57 PM schrieb Lukas Wagner: >> @@ -308,6 +308,7 @@ __PACKAGE__->register_method({ >> { subdir =3D> 'download-url' }, >> { subdir =3D> 'file-restore' }, >> { subdir =3D> 'import-metadata' }, >> + { subdir =3D> 'identity' }, > > Just bike-shedding, but I'm wondering if 'identifier' would be slightly > more natural? I can change it if you prefer, but I think I prefer 'identity', if I'm honest.