From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 39EDB1FF137 for ; Tue, 14 Apr 2026 09:24:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EDEAF23E; Tue, 14 Apr 2026 09:24:54 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Apr 2026 09:24:18 +0200 Message-Id: Subject: Re: [PATCH-SERIES manager/docs 00/18] crs docs updates + load balancer ui and docs followup From: "Daniel Kral" To: =?utf-8?q?Michael_K=C3=B6ppl?= , X-Mailer: aerc 0.21.0-136-gdb9fe9896a79-dirty References: <20260409114224.323102-1-d.kral@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776151383211 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7HLPDIKMANXPDHUJCRO3VBT6ON3F2PYH X-Message-ID-Hash: 7HLPDIKMANXPDHUJCRO3VBT6ON3F2PYH X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Apr 13, 2026 at 6:11 PM CEST, Michael K=C3=B6ppl wrote: > Tested this on my local 3-node cluster. Played around a bit with the > various settings in the UI, checking if they are set and applied > correctly in the config. Did not notice anything off except a small > cosmetic issue that I noted in a comment on the individual patch. Also > went through the docs updates, but only noticed a few typos which I also > mentioned in comments to the individual patches. Nice work! > > Consider this: > > Reviewed-by: Michael K=C3=B6ppl > Tested-by: Michael K=C3=B6ppl Thanks a lot for the review! Besides the cosmetic UI issue where I'm unsure how to best handle that, I'll integrate the feedback to the docs for the v2!