From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B84CB1FF141 for ; Mon, 13 Apr 2026 18:01:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A50E446E; Mon, 13 Apr 2026 18:01:56 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Apr 2026 18:01:49 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH manager 05/18] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.21.0 References: <20260409114224.323102-1-d.kral@proxmox.com> <20260409114224.323102-6-d.kral@proxmox.com> In-Reply-To: <20260409114224.323102-6-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776096035480 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LMKMAO5OXCE4AILGIQZPS6VT46V323ED X-Message-ID-Hash: LMKMAO5OXCE4AILGIQZPS6VT46V323ED X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote: [snip] > @@ -42,14 +46,15 @@ Ext.define('PVE.form.CRSOptions', { > name: 'ha', > fieldLabel: gettext('Scheduling Mode'), > deleteEmpty: false, > - value: '__default__', > comboItems: [ > ['__default__', Proxmox.Utils.defaultText + ' (b= asic)'], > ['basic', gettext('Basic (Resource Count)')], > ['static', gettext('Static Load')], > ['dynamic', gettext('Dynamic Load')], > ], > - defaultValue: '__default__', > + bind: { > + value: '{crsMode}', > + }, > }, > { > xtype: 'proxmoxcheckbox', > @@ -67,6 +72,7 @@ Ext.define('PVE.form.CRSOptions', { > boxLabel: gettext('Automatically rebalance HA resour= ces'), > bind: { > value: '{autoRebalancing}', > + disabled: '{!canUseAutoRebalancing}', not a big deal, but wanted to mention it nonetheless: if a user selects e.g. static mode and enables auto rebalancing and then later switches to basic mode, the checkbox remains checked visually, but the value is still set to false once submitted. It's just a cosmetic issue, but something I noticed during my testing. > }, > }, > {